Skip to content

fix: T-128 show account and provider on each subscription limit bar - #106

Merged
jaesbit merged 1 commit into
develfrom
auto-work/t128-subscription-consumption-account-provide
Jul 15, 2026
Merged

fix: T-128 show account and provider on each subscription limit bar#106
jaesbit merged 1 commit into
develfrom
auto-work/t128-subscription-consumption-account-provide

Conversation

@jaesbit

@jaesbit jaesbit commented Jul 15, 2026

Copy link
Copy Markdown
Owner

T-128 — Revisión: contexto de cuenta en las barras de consumo

El PR anterior (#104) añadió cuenta y proveedor a la tabla de sesiones pero las barras de progreso de subscription limits seguían sin indicar de qué cuenta era cada ventana.

Cambios

Protocol (packages/protocol/src/index.ts):

  • SubscriptionUsageLimit gana campos opcionales provider y account.

Server (apps/server/src/usage-subscription.ts):

  • Clave de dedup del display cambiada de limit.id a provider:account:limitId — ventanas iguales de cuentas distintas ahora generan barras separadas en vez de colapsar a la fracción más alta.
  • El campo account se deriva como scope.accountId ?? orgId ?? projectId ?? tier ?? "(shared)" y siempre está presente.

UI (apps/web/src/views/SubscriptionLimitsView.tsx):

  • Cada tarjeta de barra muestra provider · account como subtítulo debajo del label de ventana.
  • La React key es ahora compuesta (provider:account:label) para soportar barras por cuenta con mismo label de ventana.

Tests (apps/server/src/usage-subscription.test.ts):

  • 4 nuevos tests de regresión: cuentas distintas → barras separadas, propagación de campos, cadena de fallback completa (orgId → projectId → tier → "(shared)").
  • 16/16 pass en el worktree.

Each progress bar now carries a subtitle line with provider and account
(e.g. "anthropic · acc_abc") so it is immediately clear which account
each window belongs to.

Changes:
- SubscriptionUsageLimit gains optional provider and account fields;
  server always populates account via scope.accountId ?? orgId ??
  projectId ?? tier ?? "(shared)".
- Display dedup key changed from limit.id to provider:account:limitId so
  same-window limits from different accounts render as separate bars
  instead of collapsing to the highest fraction.
- SubscriptionLimitsContent shows provider · account below each label;
  falls back to "–" for pre-revision payloads. React key is now a
  composite of provider, account and label to handle per-account bars
  with the same window label.
- Four new regression tests: separate bars for distinct accountIds, field
  propagation, and the full fallback chain (orgId → projectId → tier →
  "(shared)").
@jaesbit
jaesbit merged commit be4ef96 into devel Jul 15, 2026
@jaesbit
jaesbit deleted the auto-work/t128-subscription-consumption-account-provide branch July 15, 2026 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant