T-134: add cwd folder picker directly on kanban card - #127
Merged
Conversation
- TaskCard: FolderOpen button (hover + focus-visible) with onPointerDown,
onKeyDown, onClick stopPropagation so dnd listeners are not triggered.
Accepts optional onPickCwd(task) prop; button absent when prop omitted.
- Column: threads onPickCwd through to each TaskCard.
- TasksView: single DirBrowserModal at root keyed on cwdPickerTask state;
onSelect calls tasksApi.update({cwd}) and merges the result into tasks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a
FolderOpenbutton to each kanbanTaskCardso the taskcwdcan be changed directly from the board — without opening the full task modal.How
TaskCard: optionalonPickCwd(task)prop renders a hover/focus-visibleFolderOpenbutton positioned bottom-right. Three event guards (onPointerDown,onKeyDown,onClickallstopPropagation) prevent the dnd sortable listeners from intercepting it.Column: threadsonPickCwdthrough to eachTaskCard.TasksView: singleDirBrowserModalat root, keyed oncwdPickerTaskstate.onSelectcallstasksApi.update({cwd})and merges the authoritative response back into the task list.Closes acceptance gap
The existing implementation (PR #115) put the folder picker only inside
TaskModal. The task body says "directamente desde la tarjeta"; this commit satisfies that criterion.Verified
bun run --filter '@omp-deck/web' typecheck: exit 0bun test apps/server/src/routes-workspaces.test.ts: 15/15 pass