fix(bridge): dispose superseded session handle on resume/create collision - #2
Merged
Merged
Conversation
…sion A resume/create call for a sessionId already tracked in `this.active` silently overwrote that map entry, orphaning the previous handle: its subscriptions and any in-flight turn kept running forever with no way to reach or abort it (getSession only ever returns the newest entry). Dispose the superseded instance before replacing it so at most one in-process instance ever drives a given session file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
InProcessAgentBridgekeys live sessions bysessionIdinthis.active. A resume or create call for asessionIdthat's already tracked there silently overwrote that map entry — the previous handle became orphaned: its subscriptions and any in-flight turn kept running forever with no way to reach or abort it, sincegetSessiononly ever returns the newest entry for a given id.What changed
Before inserting the new handle into
this.active, dispose the superseded instance (if any) first, so at most one in-process instance ever drives a given session file at a time.Testing
tsc --noEmitclean forapps/server.InProcessAgentBridgedirectly.