Conversation
When a C/C++ symbol has both a forward declaration (header prototype) and a real definition (implementation), Lore now correctly resolves the canonical definition: - buildSymbolDefinitionMap() tracks ForwardDefinition role (SCIP bit 64) and allows real definitions to override forward declarations regardless of document processing order. - Symbol rows for forward declarations set definition_path/definition_uri to the real implementation file instead of self-referencing the header. - Refs to such symbols also resolve to the implementation via the corrected symbolDefinitions map. This fixes declaration-to-definition directionality for C header/ implementation patterns (e.g. zstd public API), making graph consumers authoritative without requiring consumer-side heuristics. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
scip-clang emits location-based identifiers for preprocessor macros '9!', '13!' (column numbers with unstripped ! suffix). Three fixes: - extractNameFromScipSymbol: strip ! (macro) descriptor suffix - inferKindFromScipSymbol: recognize ! as macro/constant kind - scip-indexer: filter out symbols with purely numeric or location-based names (anonymous compiler-generated identifiers) On the zstd corpus this removes ~1,600 garbage symbol rows and eliminates all duplicate-name-per-file pathologies (was 107 copies of '9!' in a single file). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Bump version to 0.4.0 in package.json and package-lock.json - Refresh README.md benchmark numbers and remove tree-sitter references - Update docs/architecture.md pipeline stages to match SCIP+LSP architecture - Add historical-context banner to docs/scip-lsp-architecture.md
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #461 +/- ##
=======================================
Coverage 91.83% 91.83%
=======================================
Files 65 65
Lines 6160 6160
Branches 1726 1726
=======================================
Hits 5657 5657
Misses 503 503 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release v0.4.0
Version bump: 0.3.9 → 0.4.0
Compare:
v0.3.9...release/v0.4.0Highlights
This is a major milestone release: Lore has fully migrated from tree-sitter to a SCIP-first indexing architecture with LSP enrichment. Tree-sitter dependencies are completely removed.
Features
Fixes
Refactoring
Testing
Docs
Validation