release: v3.11.1 — dream progress spinner fix - #74
Closed
jagoff wants to merge 2 commits into
Closed
Conversation
Console(force_terminal=False) short-circuits Rich 15's is_terminal to False before isatty(), so memo emitted no ANSI and the dream pipeline's spinner/progress bar never rendered — the run looked frozen after the pre-dream inventory panel with zero feedback. Let the shared console auto-detect (Console()), and gate _make_progress on console.is_terminal (the stream it renders to) instead of sys.stderr.isatty().
Owner
Author
|
Superseded by the v3.11.2 release PR, which bundles this release's commit plus the follow-up status-line fix onto master. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Patch release v3.11.1. Restores the
memo dream runprogress spinner/bar in real terminals.Why
The shared Rich
Consolewas built withforce_terminal=False. Rich 15 short-circuitsis_terminalto the forced value before theisatty()check, so memo emitted zero ANSI and the dream pipeline's spinner/progress bar never rendered — the run looked frozen after the pre-dream inventory panel with no feedback.Fix (commit 6287ce5)
cli_common.py:Console()auto-detects the terminal (TTY → colour + spinner; pipes/tests/launchd → plain, unchanged).dream_utils._make_progress: gatedisableonconsole.is_terminal(the stream it renders to) instead ofsys.stderr.isatty().MEMO_NONINTERACTIVEoverride preserved.tests/test_dream_progress_tty.py: 4 regression tests locking the TTY gating.Verified end-to-end under a pty: ANSI + spinner + bar emit; non-TTY stays plain.
Release commit 3ad783e
Version bump 3.11.0 → 3.11.1 across all manifests + docs + CHANGELOG via
memo release bump patch. Tagv3.11.1already pushed.Test plan
ruff+mypyclean on changed files