chore: codebase cleanup — bugs, dead code, perf#20
Merged
Conversation
Bug fixes: - Fix JSON outline using bare key instead of full dotted path for nested values - Fix C# property_declaration mapped to OutlineKind::Function (now Property) - Fix empty-file guard bypassed when section param is set (0-byte mmap) - Fix format_imports using wrong entry for import block start line Performance: - Collapse double fs::metadata calls per file in callers search - Share file content via Arc<String> across call sites (was N clones per file) - Cache compiled tree-sitter queries via LazyLock<Mutex<HashMap>> - Capture SystemTime::now() once before sort (was O(n log n) syscalls) Dead code removal: - Remove unused prune() + TTL infrastructure from cache - Remove dead tool_map, record_map, maps counter chain - Remove dead is_plain_assignment + unreachable branch in truncate - Remove unused OutlineKind::Method variant and Match::column field Cleanup: - Deduplicate is_test_file into shared types::is_test_file Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Comprehensive codebase review and cleanup. No new features, no API changes, no version bump.
is_test_fileutilityNet -24 lines across 15 files. All 56 tests passing, clippy + fmt clean.
Test plan
cargo clippy -- -D warnings— cleancargo test— 56 passed, 0 failedcargo fmt --check— clean🤖 Generated with Claude Code