Correction to hasNext and hasPrevious Javadoc#1395
Merged
otaviojava merged 2 commits intojakartaee:mainfrom Mar 12, 2026
Merged
Correction to hasNext and hasPrevious Javadoc#1395otaviojava merged 2 commits intojakartaee:mainfrom
otaviojava merged 2 commits intojakartaee:mainfrom
Conversation
KyleAure
approved these changes
Mar 11, 2026
Member
KyleAure
left a comment
There was a problem hiding this comment.
Looks good, this clarifies the expected behavior well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Page.hasNext and hasPrevious say they are a way of knowing
that {@link #nextPageRequest()} will definitely not return {@code null}.that {@link #previousPageRequest()} will not return {@code null}However, nextPageRequest and previousPageRequest are written to never return
null. They likely did so at one point but were switched to raiseNoSuchElementExceptionrather than returningnull. The Javadoc for hasNext and hasPrevious needs to be updated to be consistent with that.There is no behavior change here, only a correction to the informative statement we are making to the user.
Also, I corrected some indenting in
PageRequestbut there are no updates to wording in that class.