Skip to content

Switch back to java 17 build#1410

Merged
otaviojava merged 5 commits intojakartaee:mainfrom
njr-11:switch-back-to-java-17-build
Mar 30, 2026
Merged

Switch back to java 17 build#1410
otaviojava merged 5 commits intojakartaee:mainfrom
njr-11:switch-back-to-java-17-build

Conversation

@njr-11
Copy link
Copy Markdown
Member

@njr-11 njr-11 commented Mar 26, 2026

Resolves #1341 to switch us back to building with Java 17 and generating Java 17 compatible API classes for Data 1.1.

@njr-11 njr-11 added this to the 1.1 milestone Mar 26, 2026
@njr-11 njr-11 mentioned this pull request Mar 26, 2026
Closed
otaviojava
otaviojava reviewed Mar 26, 2026
View reviewed changes
Comment thread pom.xml
<maven.javadoc.plugin.version>3.12.0</maven.javadoc.plugin.version>
<maven.source.plugin.version>3.4.0</maven.source.plugin.version>
<maven.checkstyle.plugin.version>3.6.0</maven.checkstyle.plugin.version>
<maven.checkstyle.plugin.version>3.1.2</maven.checkstyle.plugin.version>
Copy link
Copy Markdown
Contributor

@otaviojava otaviojava Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we really need to do a downgrade on this?

Copy link
Copy Markdown
Member Author

@njr-11 njr-11 Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Newer versions won't build against Java 17.

KyleAure
KyleAure reviewed Mar 30, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@KyleAure KyleAure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few things that still need to be reverted from this commit: 9f445d2

Namely:

  • tck/.../TCKArchiveProcessor.java
  • tck/.../DataSignatureTestRunner.java
  • tck-dist/.../data-tck-reference-guide.adoc
  • spec/.../README.adoc
  • README.adoc

@njr-11
Copy link
Copy Markdown
Member Author

njr-11 commented Mar 30, 2026

Looks good, just a few things that still need to be reverted from this commit: 9f445d2

Namely:

* tck/.../TCKArchiveProcessor.java

* tck/.../DataSignatureTestRunner.java

* tck-dist/.../data-tck-reference-guide.adoc

* spec/.../README.adoc

* README.adoc

Thanks - I updated the readme, but running the TCK on Java 17 is intentionally left out. We will tolerate Java 17, but we aren't requiring or expecting anyone to certify on it. The goal from the issue that was opened is "at least having API/annotations jar be Java 17 compatible letting it be up to implementations to set the bar higher" along with that we also give implementations the benefit of being able to compile a single shared source for Data 1.0 and 1.1 implementations that is built against Java 17. And some implementations might allow users to try out early access versions on Java 17 (I know this has been requested as well). None of these require the TCK to run on Java 17.

@otaviojava otaviojava merged commit cde1906 into jakartaee:main Mar 30, 2026
5 checks passed
@KyleAure KyleAure mentioned this pull request Mar 30, 2026
Closed
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@otaviojava otaviojava otaviojava approved these changes

@KyleAure KyleAure KyleAure approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.1

Development

Successfully merging this pull request may close these issues.

[Bug]: Jakarta Data currently requires Java 21, while JPA 4.0 targets Java 17.

3 participants

@njr-11 @otaviojava @KyleAure