TCK tests for Sort.nullsFirst() and nullsLast()#1432
Merged
otaviojava merged 3 commits intoApr 22, 2026
Merged
Conversation
Co-authored-by-AI: IBM Bob 1.0.1
otaviojava
reviewed
Apr 20, 2026
otaviojava
reviewed
Apr 20, 2026
| 50_000_000L, | ||
| Order.by(_Country.daylightTimeBegins.asc().nullsLast())); | ||
| } catch (IllegalArgumentException x) { | ||
| if (type.capableOfSortingNulls()) { |
Contributor
There was a problem hiding this comment.
The same here, mainly, when we talk about SortingNulls
For now, I would say, let's keep the previous strategy for type.
KyleAure
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TCK tests covering Sort methods
nullsFirst()andnullsLast().