Skip to content

Fix TCK test errors#411

Merged
otaviojava merged 2 commits intojakartaee:mainfrom
KyleAure:371-fix-basic-repository-methods
Jan 4, 2024
Merged

Fix TCK test errors#411
otaviojava merged 2 commits intojakartaee:mainfrom
KyleAure:371-fix-basic-repository-methods

Conversation

@KyleAure
Copy link
Copy Markdown
Member

@KyleAure KyleAure commented Jan 4, 2024

While running the TCK I found two errors that need to be fixed:

  • The EntityTest application did not include the correct classes to run.
  • The validation test repository used invalid query methods.

@KyleAure KyleAure added bug Something isn't working test Something test-related labels Jan 4, 2024
@KyleAure KyleAure requested a review from njr-11 January 4, 2024 15:57
@KyleAure KyleAure self-assigned this Jan 4, 2024
njr-11
njr-11 approved these changes Jan 4, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@njr-11 njr-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching these errors!

@otaviojava otaviojava merged commit 394809d into jakartaee:main Jan 4, 2024
@KyleAure KyleAure deleted the 371-fix-basic-repository-methods branch January 4, 2024 19:58
@KyleAure KyleAure mentioned this pull request Jan 8, 2024
Closed
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@njr-11 njr-11 njr-11 approved these changes

Assignees

@KyleAure KyleAure

Labels

bug Something isn't working test Something test-related

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@KyleAure @njr-11 @otaviojava