fix: update service branch to use new parent pom#386
Merged
KyleAure merged 4 commits intoMay 19, 2026
Conversation
20 tasks
njr-11
approved these changes
May 19, 2026
pzygielo
reviewed
May 19, 2026
| <doclint>none</doclint> | ||
| </configuration> | ||
| </plugin> | ||
| <!-- This plugin marks all files as needing a copyright header update in the CI builds. Even though no files are actually updated. |
There was a problem hiding this comment.
But why that happens?
- Because in shallow clone there is no actual log available for most of the files, and the checkout is performed with depth=1.
and
2. This pom explicitly says <ignoreYear>false</ignoreYear>.
glassfish-copyright-maven-plugin is broken
👀
No.
There was a problem hiding this comment.
pom in api:
Line 52 in 707b526
Member
Author
There was a problem hiding this comment.
Thanks for the explanation. @pzygielo
What would you suggest as a solution?
We could:
- Modify the checkout action to fetch the entire history
- Could increase the time of our CI builds (would need to test to find out how much of a performance impact this would have)
- Prevents copyright headers from not being updated
- Skip the copyright header check in CI builds
- Using:
-Dglassfish.copyright.skip=true - Does not prevent non-updated copyright headers from being merged.
- Does still allow developers to check copyright headers locally.
- Keep the plugin removed, and rely on code reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepare the 3.0.1-BRANCH for service release
Related #383