Restrict fpm-deployment coverage upload to the filtered src/ report#13
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix coverage job configuration in CI workflow
Restrict fpm-deployment coverage upload to the filtered Jul 16, 2026
src/ report
jalvesz
marked this pull request as ready for review
July 16, 2026 21:45
jalvesz
added a commit
that referenced
this pull request
Jul 18, 2026
…ibrary (fortran-lang#1186) * start gmres draft * add comments * remove kdim from test * use dot_product * gmres: add Hilbert matrix test * linalg: add MGS reorthogonalization to GMRES * fix: rename loop variable to avoid fypp collision * fix: hilbert sp tolerance test * fix: hilbert sp tolerance test * fix: hilbert dp tolerance test * fix: hilbert dp tolerance test for Intel 2024 1 cmake * Update test/linalg/test_linalg_solve_iterative.fypp Co-authored-by: Jeremie Vandenplas <jeremie.vandenplas@gmail.com> * Update test/linalg/test_linalg_solve_iterative.fypp Co-authored-by: Jeremie Vandenplas <jeremie.vandenplas@gmail.com> * Update test/linalg/test_linalg_solve_iterative.fypp Co-authored-by: Jeremie Vandenplas <jeremie.vandenplas@gmail.com> * Update test/linalg/test_linalg_solve_iterative.fypp Co-authored-by: Jeremie Vandenplas <jeremie.vandenplas@gmail.com> * Update test/linalg/test_linalg_solve_iterative.fypp Co-authored-by: Jeremie Vandenplas <jeremie.vandenplas@gmail.com> * fix declarations * make gmres implementation flexible by allowing switching between memory efficiency or runtime speed * add example * convert static enum to integer helper function to determine the number of colums of the gmres workspace * simplify iterations logic * replace manual given rotations and the triangular solve by lapack kernels * try removing the hilbert test for sp as it is meaningless for the selected size * Refactor coverage report generation in workflow Test proposal by copilot to fix coverage report issues. Testing in an actual PR exhibiting coverage issues because of the examples. * Restrict fpm-deployment coverage upload to the filtered `src/` report (#13) * Initial plan * Disable Codecov auto-search in coverage job --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> * add review corrections * parametrize system size --------- Co-authored-by: AlexanderGSC <alexander.gsc@gmail.com> Co-authored-by: Jeremie Vandenplas <jeremie.vandenplas@gmail.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
fpm_deploymentcoverage job was correctly generating anlcovreport filtered tosrc/, but the Codecov upload step was still auto-discovering generated*.gcovfiles underexample/. That allowedexample/to be treated as the analyzed source path instead of keeping coverage anchored tosrc/.Root cause
src/during report generation.example//test/.Change
fpm-deployment.build/coverage/coverage.info.Resulting behavior
src/remains the effective source root for coverage analysis.example/is no longer eligible to override or pollute source resolution during upload.Workflow note
lcovartifact.