Skip to content

Restrict fpm-deployment coverage upload to the filtered src/ report#13

Merged
jalvesz merged 2 commits into
gmresfrom
copilot/fix-coverage-job-config
Jul 16, 2026
Merged

Restrict fpm-deployment coverage upload to the filtered src/ report#13
jalvesz merged 2 commits into
gmresfrom
copilot/fix-coverage-job-config

Conversation

Copilot AI commented Jul 16, 2026

Copy link
Copy Markdown

The fpm_deployment coverage job was correctly generating an lcov report filtered to src/, but the Codecov upload step was still auto-discovering generated *.gcov files under example/. That allowed example/ to be treated as the analyzed source path instead of keeping coverage anchored to src/.

  • Root cause

    • The workflow filtered coverage data down to src/ during report generation.
    • The subsequent Codecov step still searched the workspace for additional coverage artifacts and picked up generated files from example/ / test/.
  • Change

    • Disable Codecov's automatic coverage file search in fpm-deployment.
    • Upload only the explicit filtered report: build/coverage/coverage.info.
  • Resulting behavior

    • src/ remains the effective source root for coverage analysis.
    • example/ is no longer eligible to override or pollute source resolution during upload.
    • Build/test behavior in the workflow remains unchanged.
  • Workflow note

    • Added an inline comment documenting why the upload must be restricted to the filtered lcov artifact.
- name: Upload coverage report
  uses: codecov/codecov-action@v4
  with:
    token: ${{ secrets.CODECOV_TOKEN }}
    disable_search: true
    files: build/coverage/coverage.info

Copilot AI changed the title [WIP] Fix coverage job configuration in CI workflow Restrict fpm-deployment coverage upload to the filtered src/ report Jul 16, 2026
Copilot AI requested a review from jalvesz July 16, 2026 21:43
@jalvesz
jalvesz marked this pull request as ready for review July 16, 2026 21:45
@jalvesz
jalvesz merged commit 7cbbf9a into gmres Jul 16, 2026
@jalvesz
jalvesz deleted the copilot/fix-coverage-job-config branch July 16, 2026 21:46
jalvesz added a commit that referenced this pull request Jul 18, 2026
…ibrary (fortran-lang#1186)

* start gmres draft

* add comments

* remove kdim from test

* use dot_product

* gmres: add Hilbert matrix test

* linalg: add MGS reorthogonalization to GMRES

* fix: rename loop variable to avoid fypp collision

* fix: hilbert sp tolerance test

* fix: hilbert sp tolerance test

* fix: hilbert dp tolerance test

* fix: hilbert dp tolerance test for Intel 2024 1 cmake

* Update test/linalg/test_linalg_solve_iterative.fypp

Co-authored-by: Jeremie Vandenplas <jeremie.vandenplas@gmail.com>

* Update test/linalg/test_linalg_solve_iterative.fypp

Co-authored-by: Jeremie Vandenplas <jeremie.vandenplas@gmail.com>

* Update test/linalg/test_linalg_solve_iterative.fypp

Co-authored-by: Jeremie Vandenplas <jeremie.vandenplas@gmail.com>

* Update test/linalg/test_linalg_solve_iterative.fypp

Co-authored-by: Jeremie Vandenplas <jeremie.vandenplas@gmail.com>

* Update test/linalg/test_linalg_solve_iterative.fypp

Co-authored-by: Jeremie Vandenplas <jeremie.vandenplas@gmail.com>

* fix declarations

* make gmres implementation flexible by allowing switching between memory efficiency or runtime speed

* add example

* convert static enum to integer helper function to determine the number of colums of the gmres workspace

* simplify iterations logic

* replace manual given rotations and the triangular solve by lapack kernels

* try removing the hilbert test for sp as it is meaningless for the selected size

* Refactor coverage report generation in workflow

Test proposal by copilot to fix coverage report issues. Testing in an actual PR exhibiting coverage issues because of the examples.

* Restrict fpm-deployment coverage upload to the filtered `src/` report (#13)

* Initial plan

* Disable Codecov auto-search in coverage job

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>

* add review corrections

* parametrize system size

---------

Co-authored-by: AlexanderGSC <alexander.gsc@gmail.com>
Co-authored-by: Jeremie Vandenplas <jeremie.vandenplas@gmail.com>
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants