Skip to content

update project to fit webpack2#23

Merged
jamesandersen merged 3 commits intojamesandersen:masterfrom
CntChen:master
Mar 7, 2017
Merged

update project to fit webpack2#23
jamesandersen merged 3 commits intojamesandersen:masterfrom
CntChen:master

Conversation

@CntChen
Copy link

@CntChen CntChen commented Feb 22, 2017

When using this plugin with webpack2.2.1, an error accoour:

TypeError: Cannot read property 'hasOwnProperty' of undefined
 .../string-replace-webpack-plugin/loader.js:12:29)

This plugin add custom propertie options to webpack compiler object. but webpack 2 no longer allows custom properties in configuration.

So I use StringReplacePlugin static property REPLACE_OPTIONS to store plugin's options and solve this error.

@josephliccini
Copy link

@jamesandersen this would be great to have in since I am running into the same issues in Webpack 2.2.1

@jamesandersen jamesandersen merged commit ab4694c into jamesandersen:master Mar 7, 2017
@jamesandersen
Copy link
Owner

@CntChen thanks for the PR. @CntChen and @josephliccini you should find the new version on NPM now.

@josephliccini
Copy link

josephliccini commented Mar 7, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants