update project to fit webpack2#23
Merged
jamesandersen merged 3 commits intojamesandersen:masterfrom Mar 7, 2017
CntChen:master
Merged
update project to fit webpack2#23jamesandersen merged 3 commits intojamesandersen:masterfrom CntChen:master
jamesandersen merged 3 commits intojamesandersen:masterfrom
CntChen:master
Conversation
|
@jamesandersen this would be great to have in since I am running into the same issues in Webpack 2.2.1 |
Owner
|
@CntChen thanks for the PR. @CntChen and @josephliccini you should find the new version on NPM now. |
|
Excellent! Thanks for this and this library :)
…Sent from my iPhone
On Mar 6, 2017, at 8:19 PM, James Andersen ***@***.***> wrote:
@CntChen thanks for the PR. @CntChen and @josephliccini you should find the new version on NPM now.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using this plugin with webpack2.2.1, an error accoour:
This plugin add custom propertie
optionsto webpack compiler object. but webpack 2 no longer allows custom properties in configuration.So I use
StringReplacePluginstatic propertyREPLACE_OPTIONSto store plugin's options and solve this error.