Closed
Conversation
Author
|
@jamesandersen have you had a chance to look this over? |
Owner
|
Hey Rowan,
My apologies for the significant delay... I just haven't used this
plugin myself for over 2 years so it tends to slip down on my priority
list; probably should hand off maintenance to someone... ;-)
The change looks pretty straightforward/safe to me. That said, I haven't
touched this plugin in a while and just grabbing master yesterday (without
your changes) I found two of the unit tests broken (possibly due to
underlying changes in the 2.x webpack releases) so I've got some work to do
there first.
If you could add a unit test covering your change that would be ideal.
The earliest I'll possibly get back to this is next week as I'm heading out
of town for the weekend.
- James
…On 5 July 2017 at 08:17, Rowan Oulton ***@***.***> wrote:
@jamesandersen <https://github.com/jamesandersen> have you had a chance
to look this over?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#26 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACBXmC-Go6yRfO7x7bG8DA29VNpCcNfnks5sK5r4gaJpZM4NEp2I>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey!
This is a potential solution for #25 to make the plugin compatible with webpack's
recordsPathoption. It allows for anidto be passed in instead of a randomly generating string.Let me know what you think, and if you're happy with the concept I'll see about writing some tests.