preserve loader "this" context for "replacement" function#7
Closed
mdreizin wants to merge 3 commits intojamesandersen:masterfrom
mdreizin:master
Closed
preserve loader "this" context for "replacement" function#7mdreizin wants to merge 3 commits intojamesandersen:masterfrom mdreizin:master
mdreizin wants to merge 3 commits intojamesandersen:masterfrom
mdreizin:master
Conversation
Owner
|
Thanks for the contribution; this is a nice improvement. I appreciate the tests as well. |
Owner
|
I've rebased the branch and merged it in #8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It helps to save loader
thiscontext during replacement. It is very useful in case when you need to have access tothiscontext, for instancethis.options: