Skip to content

feat(i18n): add Korean (ko) locale with 559 translation keys - #814

Merged
jamiepine merged 3 commits into
jamiepine:mainfrom
TedChang-Lim:main
Jul 20, 2026
Merged

feat(i18n): add Korean (ko) locale with 559 translation keys#814
jamiepine merged 3 commits into
jamiepine:mainfrom
TedChang-Lim:main

Conversation

@TedChang-Lim

@TedChang-Lim TedChang-Lim commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Summary

Added Korean (ko) locale support to Voicebox's i18n system.

Changes

  • Created app/src/i18n/locales/ko/translation.json with 559 translation keys — all sections fully translated
  • Updated app/src/i18n/index.ts to register the Korean locale:
    • Import ko translation module
    • Added ko to SUPPORTED_LANGUAGES as '한국어'
    • Added ko resource bundle

Details

  • The Korean translation follows the same structure as the existing English locale
  • All 559 translation keys are covered, including:
    • Common UI strings, navigation, captures, voice profiles
    • Audio channels, effects, presets
    • Stories, generation, compose features
    • Full settings (General, Generation, Captures, MCP, GPU)
    • Model management, about section
  • i18next plural rules handled correctly (Korean uses "other" form like Japanese)

Testing

  • Build and run locally to verify Korean displays correctly in all sections
  • Language can be selected in Settings → Language dropdown

Related

  • i18n system added in v0.4.2

Summary by CodeRabbit

  • New Features
    • Added Korean language support across the app.
    • Introduced a complete Korean translation set for core UI text, messages, settings, and notifications.
    • Korean is now available as a selectable language option.

@coderabbitai

coderabbitai Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: b7c943c3-632a-43e1-8424-ef9a65d9a827

📥 Commits

Reviewing files that changed from the base of the PR and between d374e1a and c4f155c.

📒 Files selected for processing (2)
  • app/src/i18n/index.ts
  • app/src/i18n/locales/ko/translation.json
🚧 Files skipped from review as they are similar to previous changes (2)
  • app/src/i18n/locales/ko/translation.json
  • app/src/i18n/index.ts

📝 Walkthrough

Walkthrough

Adds Korean (ko) support by registering the locale in the i18n configuration and providing Korean translations for the application’s UI namespaces, including placeholders and pluralized messages.

Changes

Korean Locale Support

Layer / File(s) Summary
Korean locale registration and translations
app/src/i18n/index.ts, app/src/i18n/locales/ko/translation.json
Imports and registers Korean in SUPPORTED_LANGUAGES and i18n.init resources, and adds Korean translations for common controls, captures, voices, profiles, effects, stories, settings, history, generation, and models.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: adding the Korean locale and its translation set to i18n.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@app/src/i18n/locales/ko/translation.json`:
- Line 448: The ko translation entry for descriptionPlaceholder contains mixed
Chinese text, so update the localized string to be fully Korean in the
translation.json locale file. In the relevant translation key, replace the
embedded “做什么” text with a Korean equivalent such as “무엇을” or rephrase the whole
placeholder to a natural Korean sentence, and keep the existing meaning
consistent with the surrounding i18n entries.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: dea1f36f-d04e-4bb0-9690-e0a272502c8e

📥 Commits

Reviewing files that changed from the base of the PR and between da79e37 and d374e1a.

📒 Files selected for processing (2)
  • app/src/i18n/index.ts
  • app/src/i18n/locales/ko/translation.json

Comment thread app/src/i18n/locales/ko/translation.json Outdated

@jamiepine jamiepine left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated against current main. Korean now has exact 850/850 key parity, no missing or extra keys, no interpolation or inline-tag mismatches, and the mixed Chinese placeholder was corrected. Frontend typecheck and production web build pass.

@jamiepine
jamiepine merged commit e6cf50c into jamiepine:main Jul 20, 2026
1 check passed
jamiepine added a commit that referenced this pull request Jul 20, 2026
* feat(i18n): add Korean (ko) locale with 559 translation keys

* fix(i18n): complete Korean translations for current UI

---------

Co-authored-by: Jamie Pine <ijamespine@me.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants