feat(i18n): add Korean (ko) locale with 559 translation keys - #814
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughAdds Korean ( ChangesKorean Locale Support
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@app/src/i18n/locales/ko/translation.json`:
- Line 448: The ko translation entry for descriptionPlaceholder contains mixed
Chinese text, so update the localized string to be fully Korean in the
translation.json locale file. In the relevant translation key, replace the
embedded “做什么” text with a Korean equivalent such as “무엇을” or rephrase the whole
placeholder to a natural Korean sentence, and keep the existing meaning
consistent with the surrounding i18n entries.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: dea1f36f-d04e-4bb0-9690-e0a272502c8e
📒 Files selected for processing (2)
app/src/i18n/index.tsapp/src/i18n/locales/ko/translation.json
jamiepine
left a comment
There was a problem hiding this comment.
Updated against current main. Korean now has exact 850/850 key parity, no missing or extra keys, no interpolation or inline-tag mismatches, and the mixed Chinese placeholder was corrected. Frontend typecheck and production web build pass.
* feat(i18n): add Korean (ko) locale with 559 translation keys * fix(i18n): complete Korean translations for current UI --------- Co-authored-by: Jamie Pine <ijamespine@me.com>
Summary
Added Korean (ko) locale support to Voicebox's i18n system.
Changes
app/src/i18n/locales/ko/translation.jsonwith 559 translation keys — all sections fully translatedapp/src/i18n/index.tsto register the Korean locale:kotranslation modulekotoSUPPORTED_LANGUAGESas '한국어'koresource bundleDetails
Testing
Related
Summary by CodeRabbit