[WIP] Split out minifb, viewer, and possibly other things into features#137
Conversation
|
@glasgow-haskell-omelette Thanks for the PR and the work on splitting out things into on-by-default features. That said, I think this still needs further refinement. For example:
In any case, refining the features is an important step, and I will take this task |
Depends. Really the main issue this one had with it is that it pulled in ureq and OpenSSL. Just adding support for different backends would be very little code and have very little impact on compile times. So perhaps there should be a "network" feature? This PR in its current form is more or less just some small changes this one made in order to reduce its compilation times. It might iterate on it more later (although it ended up switching from ONNX to MNN, and so isn't actively using usls) |
|
@glasgow-haskell-omelette I’ve added the |
|
oki! will do if something comes up |
what: splitting out things into on-by-default features
why: to not include unnecessary components in the supply chain and not increase binary size and compilation time for no reason
draft since the ureq split isn't exactly perfect yet