Skip to content

Backport #3859: Improve focus handling and accessibility in Connect dialog - #3870

Merged
pljones merged 1 commit into
release/3_12from
release/3_12-connectdlg-focus-server
Aug 8, 2026
Merged

Backport #3859: Improve focus handling and accessibility in Connect dialog#3870
pljones merged 1 commit into
release/3_12from
release/3_12-connectdlg-focus-server

Conversation

@softins

@softins softins commented Aug 8, 2026

Copy link
Copy Markdown
Member

Short description of changes

Squashed backport of #3859 to 3.12.x

  • Deselect server in list when clicking on address box
  • No longer need handler for server addr edit text changed
  • Save current server item and restore on regaining focus
  • Disable tab-key navigation in the server list Tab and Shift+Tab were being consumed to move between tree items rather than moving focus through the dialog. Arrow-key navigation within the tree remains unchanged. This restores conventional keyboard navigation and improves accessibility.
  • Make savedServer usage more robust.
  • Fix double-Enter needed to connect to custom server in keyboard mode

CHANGELOG: Client: Improve server list navigation in Connect Dialog.

Context: Fixes an issue?

Fixes #3857

Does this change need documentation? What needs to be documented and how?

No

Status of this Pull Request

Tested and ready to merge.

What is missing until this pull request can be merged?

Nothing

Checklist

  • I've verified that this Pull Request follows the general code principles
  • I tested my code and it does what I want
  • My code follows the style guide
  • I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • I've filled all the content above

* Deselect server in list when clicking on address box
* No longer need handler for server addr edit text changed
* Save current server item and restore on regaining focus
* Disable tab-key navigation in the server list
  Tab and Shift+Tab were being consumed to move between tree items rather than moving focus through the dialog.
  Arrow-key navigation within the tree remains unchanged.
  This restores conventional keyboard navigation and improves accessibility.
* Make savedServer usage more robust.
* Fix double-Enter needed to connect to custom server in keyboard mode
@softins softins changed the title Improve focus handling and accessibility in Connect dialog Backport #3859: Improve focus handling and accessibility in Connect dialog Aug 8, 2026
@softins

softins commented Aug 8, 2026

Copy link
Copy Markdown
Member Author

This could wait until #3872 is merged to fix #3871 , then we can include it here by cherry-picking.

@pljones pljones added the bug Something isn't working label Aug 8, 2026
@github-project-automation github-project-automation Bot moved this to Triage in Tracking Aug 8, 2026
@pljones pljones added this to the Release 3.12.4 milestone Aug 8, 2026
@github-project-automation github-project-automation Bot moved this from Triage to Waiting on Team in Tracking Aug 8, 2026
@pljones
pljones merged commit 28e3a1c into release/3_12 Aug 8, 2026
@github-project-automation github-project-automation Bot moved this from Waiting on Team to Done in Tracking Aug 8, 2026
@pljones
pljones deleted the release/3_12-connectdlg-focus-server branch August 8, 2026 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants