Updated download links from corrados to jamulussoftware #930
Merged
Conversation
changed corrados to jamulussoftware
changed corrados to jamulussoftware
ann0see
approved these changes
Jan 31, 2021
ann0see
left a comment
ann0see
left a comment
Member
There was a problem hiding this comment.
Although I didn't test it, I think it should work ok. There might be some changes needed to these files (quoting could be improved). But that's another issue
jerogee
approved these changes
Jan 31, 2021
jerogee
left a comment
jerogee
left a comment
Contributor
There was a problem hiding this comment.
Tested tag name extraction and fetching with wget for new links. Works as expected.
Other than that: having 3 scripts that are 99% identical does not make sense. Should be merged. But that is another for another issue to improve.
pljones
approved these changes
Jan 31, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated download links from corrados to jamulussoftware in installscripts