Allow tracing of external sources of allocation#5
Merged
Merged
Conversation
lukemaurer
reviewed
Nov 23, 2020
tmcgilchrist
referenced
this pull request
in tmcgilchrist/memtrace
May 6, 2025
Add self_memory_map example for macos
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Memtrace.External.{alloc,free}, so that non-heap allocations can be tracked in the same trace as heap allocations.
This works by reimplementing the Statmemprof sampling logic in OCaml, using this second sampler for non-heap allocations. The optimised sampling logic in geometric_sampler.ml is a port of the C code in the OCaml runtime and is extremely tricky. I recommend reviewing by reading the mli and tests.
cc @lukemaurer