Replace 'is_major' with 'source', which might be Minor, Major or External#8
Merged
Conversation
lukemaurer
reviewed
Dec 8, 2020
| | 0 -> Minor | ||
| | 1 -> Major | ||
| | 2 -> External | ||
| | _ -> bad_format "is_major" in |
Contributor
There was a problem hiding this comment.
Should this now say bad_format "source"?
tmcgilchrist
pushed a commit
to tmcgilchrist/memtrace
that referenced
this pull request
May 21, 2025
Add brief section on the Go garbage collector.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a followup to #5, which introduced the support for external allocations. This patch marks external allocations as such in the memtrace files, so that the viewer can distinguish them.
The codes for minor / major / external are chosen to be compatible with the old is_major field, so the format of traces that don't include external allocs doesn't change.