feat: pwm used for button led again#36
Merged
Merged
Conversation
cpunt
reviewed
Mar 5, 2026
cpunt
left a comment
cpunt
left a comment
Contributor
There was a problem hiding this comment.
Overall lgtm, just 3 nitpicks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
This returns a feature that uses PWM to control the power button LED.
In steady state, the LED is set to on, and at all other times it uses PWM ramp to sawtooth between 0 and 1 over a 2 second period.
Related Issues, Tickets & Documents
https://app.clickup.com/t/869byyx7h
Manual test
Manual test description
Deploy on a test MCU board
Observe pulsing light
Added tests?
Added to documentation?