Skip to content
This repository was archived by the owner on Jul 4, 2025. It is now read-only.

Conversation

@louis-jan
Copy link
Contributor

@louis-jan louis-jan commented Feb 22, 2024

Descriptions

This pull request refactors whisperCPP & llamaCPP to extend base classes, also comply google style guide

  • Extends base class
  • Comply google style guide
  • Add model load state & api
  • Clean code

Issues

@louis-jan louis-jan force-pushed the refactor/whisper-extends-base-class branch 2 times, most recently from 53baecf to 09113e2 Compare February 25, 2024 17:30
@louis-jan louis-jan changed the title refactor: whisper extends base class refactor: modules extends base classes - comply google style guide Feb 25, 2024
@louis-jan louis-jan force-pushed the refactor/whisper-extends-base-class branch 3 times, most recently from 2bfad6e to faaf774 Compare February 26, 2024 08:04
@louis-jan louis-jan marked this pull request as ready for review February 26, 2024 08:04
@louis-jan louis-jan force-pushed the refactor/whisper-extends-base-class branch from faaf774 to bb192c7 Compare February 26, 2024 08:18
@louis-jan louis-jan force-pushed the refactor/whisper-extends-base-class branch from bb192c7 to d5478a1 Compare February 27, 2024 16:23
@louis-jan louis-jan force-pushed the refactor/whisper-extends-base-class branch from d5478a1 to 035f0f4 Compare February 28, 2024 09:42
Copy link
Contributor

@tikikun tikikun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tikikun tikikun merged commit a0ebbec into main Feb 28, 2024
@louis-jan louis-jan deleted the refactor/whisper-extends-base-class branch May 24, 2024 03:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants