Fix two comments naming builtins that were removed or have since landed - #14
Merged
Conversation
`serialize`/`serialize_file` left the language in #8, but two comments still describe them as live keyword-prefix builtins: `push_wrapped`'s list of the shapes it builds, and the evaluator's header. The evaluator header had drifted further than that. Its list of what this pass deliberately leaves unimplemented also still named `async`, `sha256` and `File`, all three of which run today - `sha256` since #8 gave it a real implementation, and `async`/`File` well before that. What is actually scoped out is `cached`, `import`, `#context`, and the static-vs-runtime distinction for `check`/`static_check`. `Bytes` comes off the list too: the value type exists and flows through the evaluator, and the gap that remains - no literal syntax for it - is already recorded where it belongs, at the top of value.odin. A comment that lists the unfinished work is worth keeping accurate precisely because it is where someone looks to find unfinished work; one that names three finished things and two deleted ones sends them the wrong way. Comments only, no behaviour change. Suite green at 160 tests. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two comments in
src/still describe the language as it was before #8.src/parser.odin—push_wrapped's doc line lists the keyword-prefixshapes it builds, and still includes
serialize/serialize_file, which #8removed from the language.
src/eval.odin— the file header's list of what this evaluator passdeliberately leaves unimplemented. Besides the same two removed keywords, it
named three things that run today:
asyncspawn_async, andLANGUAGE.mddocuments itsha256eval_sha256,src/hash.odin)FileFile_Value,loadfile, file displayWhat is genuinely still scoped out is
cached,import,#context, and thestatic-vs-runtime distinction for
check/static_check(onecaseruns bothas runtime checks). That is what the header now says.
Bytescomes off the list as well: the value type exists and flows through theevaluator, and the one real gap — no literal syntax for it — is already
recorded at the top of
src/value.odin, which is the better place for it.A header comment enumerating the unfinished work is exactly where someone looks
to find unfinished work, so it is worth keeping true; this one was pointing at
three finished features and two deleted ones.
Comments only — no behaviour change.
odin test srcis green at 160 tests.🤖 Generated with Claude Code