Skip to content

root - chore: defense - disable checkout credential persistence - #467

Merged
jaredwray merged 3 commits into
mainfrom
cursor/defense-persist-credentials-9ffa
Aug 16, 2026
Merged

root - chore: defense - disable checkout credential persistence#467
jaredwray merged 3 commits into
mainfrom
cursor/defense-persist-credentials-9ffa

Conversation

@jaredwray

@jaredwray jaredwray commented Aug 16, 2026

Copy link
Copy Markdown
Owner

Summary

Set persist-credentials: false on every actions/checkout so job tokens are not left in the workspace.

Status update

DEFENSE_IN_DEPTH.md: persist-credentials: false on checkouts that don't push → (PR #467 pending)
DEFENSE_IN_DEPTH.md: permissions: contents: read on every workflow → PR #466 (reconciled)

Changes

  • Add persist-credentials: false to tests, code-coverage, release, deploy-site, build-binaries, and codeql checkouts

Verification

  • Confirmed no checkout in this repo pushes with the default token (build-binaries uses github.token for gh release upload)
  • pnpm test (831 tests, 100% coverage)

Reference

defense-in-depth-nodejs § 4

Open in Web Open in Cursor 

@cursor
cursor Bot force-pushed the cursor/defense-actions-permissions-9ffa branch from a7daf35 to b5bf3bd Compare August 16, 2026 17:45
Base automatically changed from cursor/defense-actions-permissions-9ffa to main August 16, 2026 17:52
cursoragent and others added 3 commits August 16, 2026 17:52
Set persist-credentials: false on every actions/checkout that does not
need to push, so the job token is not left in the workspace.

Co-authored-by: Jared Wray <me@jaredwray.com>
Co-authored-by: Jared Wray <me@jaredwray.com>
Reconcile the § 4 contents: read checkbox against merged PR #466.

Co-authored-by: Jared Wray <me@jaredwray.com>
@cursor
cursor Bot force-pushed the cursor/defense-persist-credentials-9ffa branch from 63f07ed to 8b473fd Compare August 16, 2026 17:53
@jaredwray
jaredwray marked this pull request as ready for review August 16, 2026 17:53
@codecov

codecov Bot commented Aug 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (8a9fc23) to head (8b473fd).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #467   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines         2760      2760           
  Branches       845       836    -9     
=========================================
  Hits          2760      2760           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jaredwray
jaredwray merged commit 6059b10 into main Aug 16, 2026
12 checks passed
@jaredwray
jaredwray deleted the cursor/defense-persist-credentials-9ffa branch August 16, 2026 18:08
cursor Bot pushed a commit that referenced this pull request Aug 16, 2026
Reconcile the § 4 persist-credentials checkbox against merged PR #467.

Co-authored-by: Jared Wray <me@jaredwray.com>
jaredwray added a commit that referenced this pull request Aug 16, 2026
* root - chore: defense - add Socket Firewall to every job

Install Socket Firewall Free immediately after checkout on every job so
later package installs are wrapped even if a job does not install today.

Co-authored-by: Jared Wray <me@jaredwray.com>

* root - chore: defense - record Socket Firewall PR number

Co-authored-by: Jared Wray <me@jaredwray.com>

* root - chore: defense - mark persist-credentials as merged

Reconcile the § 4 persist-credentials checkbox against merged PR #467.

Co-authored-by: Jared Wray <me@jaredwray.com>

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
@jaredwray jaredwray mentioned this pull request Aug 17, 2026
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants