Skip to content

mono - chore: upgrade TypeScript and build tooling - #1987

Merged
jaredwray merged 1 commit into
mainfrom
claude/keyv-dependency-maintenance-77m3u1
Jul 2, 2026
Merged

mono - chore: upgrade TypeScript and build tooling#1987
jaredwray merged 1 commit into
mainfrom
claude/keyv-dependency-maintenance-77m3u1

Conversation

@jaredwray

Copy link
Copy Markdown
Owner

Please check if the PR fulfills these requirements

  • Followed the Contributing and Code of Conduct guidelines.
  • Tests for the changes have been added (for bug fixes/features) with 100% code coverage. — N/A, dependency-only change; existing test suites pass.

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Chore — upgrades build tooling (bundler + docs generator). No source changes.

Versions

  • tsdown 0.22.2 → 0.22.3 (root — bundler used by all packages' build)
  • docula 2.0.0 → 2.1.0 (@keyv/website — docs site generator)

Tests

  • pnpm build passes (tsdown builds all packages)
  • biome check + vitest pass for core/keyv
  • docula 2.1.0 runs the full website build pipeline (verified locally; the run only stops at the final GitHub-releases fetch, which needs an API token not present in this environment — unrelated to the upgrade)

Second PR in the dependency-management dev phase (TypeScript / build tooling group).


Generated by Claude Code

- tsdown 0.22.2 -> 0.22.3
- docula 2.0.0 -> 2.1.0

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WVzS34CgyLpVDdJ9urfWxZ

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates project dependencies, upgrading tsdown to version 0.22.3 in the root package.json and docula to version 2.1.0 in the website's package.json. The pnpm-lock.yaml file has been updated accordingly to lock the new versions and their transitive dependencies. There are no review comments, and I have no feedback to provide.

@socket-security

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addeddocula@​2.1.07910010094100
Addedtsdown@​0.22.3981008896100

View full report

@socket-security

Copy link
Copy Markdown

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert  (click "▶" to expand/collapse)
Warn High
Obfuscated code: npm @emnapi/runtime is 90.0% likely obfuscated

Confidence: 0.90

Location: Package overview

From: pnpm-lock.yamlnpm/tsdown@0.22.3npm/@emnapi/runtime@1.11.1

ℹ Read more on: This package | This alert | What is obfuscated code?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/@emnapi/runtime@1.11.1. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

@codecov

codecov Bot commented Jul 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (8dcfc26) to head (d656660).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1987   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           55        55           
  Lines         4887      4887           
  Branches       785       779    -6     
=========================================
  Hits          4887      4887           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jaredwray
jaredwray merged commit da17ee7 into main Jul 2, 2026
14 checks passed
@jaredwray
jaredwray deleted the claude/keyv-dependency-maintenance-77m3u1 branch July 2, 2026 16:50

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d6566609ca

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread pnpm-lock.yaml
engines: {node: ^22.18.0 || >=24.0.0}
docula@2.1.0:
resolution: {integrity: sha512-lNsIM9ZaLU7+r7sHpHnBgjt6pOSl2Yc2QLbBrCvjLEn8SIlvnhLiXyQ7o4rmw+36CvSB/ZkF2QXABOpcyAM8nQ==}
engines: {node: ^22.19.0 || >=24.0.0}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Raise the advertised Node floor for Docula 2.1

With this upgrade, the locked docula@2.1.0 package now declares node: ^22.19.0 || >=24.0.0, while the repo root still advertises support for >= 22.18.0. Anyone on Node 22.18.x is therefore using a runtime the new website tooling explicitly does not support, and installs with engine checks or pnpm website:build can fail despite satisfying the repository's own engines range. Please either bump the root Node requirement to at least 22.19.0 or keep the website on a Docula version compatible with 22.18.x.

Useful? React with 👍 / 👎.

Comment thread pnpm-lock.yaml
engines: {node: ^22.18.0 || >=24.0.0}
tsdown@0.22.3:
resolution: {integrity: sha512-louqbfA8Qf//B9jTTL0FPtXTNpjCWv1VPkbcmQMph2pTpzs+LnB1tbe4tDDRVpo2BjF5SgUXaTZe45SxB8pWHg==}
engines: {node: ^22.18.0 || >=24.11.0}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Exclude unsupported early Node 24 builds

The new tsdown@0.22.3 build tool explicitly supports Node ^22.18.0 || >=24.11.0, but the repo and packages still advertise >= 22.18.0, which includes Node 24.0 through 24.10. In those Node 24.x environments, pnpm build invokes tsdown for every package and can run on a runtime that the upgraded toolchain intentionally dropped, so the advertised engine range should be narrowed or the upgrade held back.

Useful? React with 👍 / 👎.

This was referenced Aug 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants