mono - chore: upgrade TypeScript and build tooling - #1987
Conversation
- tsdown 0.22.2 -> 0.22.3 - docula 2.0.0 -> 2.1.0 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WVzS34CgyLpVDdJ9urfWxZ
There was a problem hiding this comment.
Code Review
This pull request updates project dependencies, upgrading tsdown to version 0.22.3 in the root package.json and docula to version 2.1.0 in the website's package.json. The pnpm-lock.yaml file has been updated accordingly to lock the new versions and their transitive dependencies. There are no review comments, and I have no feedback to provide.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1987 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 55 55
Lines 4887 4887
Branches 785 779 -6
=========================================
Hits 4887 4887 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d6566609ca
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| engines: {node: ^22.18.0 || >=24.0.0} | ||
| docula@2.1.0: | ||
| resolution: {integrity: sha512-lNsIM9ZaLU7+r7sHpHnBgjt6pOSl2Yc2QLbBrCvjLEn8SIlvnhLiXyQ7o4rmw+36CvSB/ZkF2QXABOpcyAM8nQ==} | ||
| engines: {node: ^22.19.0 || >=24.0.0} |
There was a problem hiding this comment.
Raise the advertised Node floor for Docula 2.1
With this upgrade, the locked docula@2.1.0 package now declares node: ^22.19.0 || >=24.0.0, while the repo root still advertises support for >= 22.18.0. Anyone on Node 22.18.x is therefore using a runtime the new website tooling explicitly does not support, and installs with engine checks or pnpm website:build can fail despite satisfying the repository's own engines range. Please either bump the root Node requirement to at least 22.19.0 or keep the website on a Docula version compatible with 22.18.x.
Useful? React with 👍 / 👎.
| engines: {node: ^22.18.0 || >=24.0.0} | ||
| tsdown@0.22.3: | ||
| resolution: {integrity: sha512-louqbfA8Qf//B9jTTL0FPtXTNpjCWv1VPkbcmQMph2pTpzs+LnB1tbe4tDDRVpo2BjF5SgUXaTZe45SxB8pWHg==} | ||
| engines: {node: ^22.18.0 || >=24.11.0} |
There was a problem hiding this comment.
Exclude unsupported early Node 24 builds
The new tsdown@0.22.3 build tool explicitly supports Node ^22.18.0 || >=24.11.0, but the repo and packages still advertise >= 22.18.0, which includes Node 24.0 through 24.10. In those Node 24.x environments, pnpm build invokes tsdown for every package and can run on a runtime that the upgraded toolchain intentionally dropped, so the advertised engine range should be narrowed or the upgrade held back.
Useful? React with 👍 / 👎.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Chore — upgrades build tooling (bundler + docs generator). No source changes.
Versions
tsdown0.22.2 → 0.22.3 (root — bundler used by all packages'build)docula2.0.0 → 2.1.0 (@keyv/website— docs site generator)Tests
pnpm buildpasses (tsdown builds all packages)biome check+vitestpass for core/keyvdocula2.1.0 runs the full website build pipeline (verified locally; the run only stops at the final GitHub-releases fetch, which needs an API token not present in this environment — unrelated to the upgrade)Second PR in the dependency-management dev phase (TypeScript / build tooling group).
Generated by Claude Code