bigmap - chore: upgrade hashery (breaking) - #2000
Merged
Merged
Conversation
- hashery 2.0.0 -> 3.0.0 (major) hashery v3's breaking change raises the minimum Node.js to >=22.18 and bumps its internal hookified to 3.x. keyv already satisfies both (.nvmrc is 24, engines.node ">= 22.18.0", hookified already at 3.0.1). The Hashery public API is unchanged, and @keyv/bigmap only re-exports the Hashery class, so no code changes are required. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WVzS34CgyLpVDdJ9urfWxZ
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the dependency hashery from version ^2.0.0 to ^3.0.0 in core/bigmap/package.json and updates the lockfile pnpm-lock.yaml accordingly, including updating hashery's dependency hookified to version 3.0.1. There are no review comments, and I have no feedback to provide.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2000 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 55 55
Lines 4887 4887
Branches 779 780 +1
=========================================
Hits 4887 4887 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Chore — major upgrade of
hashery(2 → 3) for@keyv/bigmap.Versions
hashery2.0.0 → 3.0.0 (@keyv/bigmap)Breaking notes
hashery v3's breaking changes are runtime/toolchain only — no public API changes:
.nvmrc= 24, rootengines.node=>= 22.18.0).hookifiedbumped to 3.x. keyv is already onhookified@3.0.1.@keyv/bigmaponly re-exports theHasheryclass (export { Hashery } from "hashery"), and the class API is unchanged, so no code changes are required.Tests
pnpm buildpasses for@keyv/bigmappnpm test:cipasses (biome + 54 tests)new Hashery().toNumberSync(...)andnew Hashery({ defaultAlgorithmSync: "fnv1" })work as documented in the READMERuntime phase — breaking major (
hashery).Generated by Claude Code