Skip to content

mysql - fix: resolve TypeScript errors - #2011

Merged
jaredwray merged 2 commits into
mainfrom
agent/mysql-fix-typescript-errors
Jul 17, 2026
Merged

mysql - fix: resolve TypeScript errors#2011
jaredwray merged 2 commits into
mainfrom
agent/mysql-fix-typescript-errors

Conversation

@jaredwray

Copy link
Copy Markdown
Owner

Summary

  • type the flattened setMany() values as mysql2 SqlValue entries at the formatting boundary
  • add the explicit .js extension required by NodeNext for the KeyvMysqlOptions type re-export

Why

A strict TypeScript check failed because the unconstrained bulk-entry generic was not assignable to mysql2's formatter input type, and the relative type export omitted the runtime extension required by NodeNext module resolution. The bundler transpiled successfully, which allowed both errors to go unnoticed.

Impact

This is a type-only compatibility fix. It does not change the generated SQL or runtime adapter behavior.

Validation

  • tsc -p storage/mysql/tsconfig.json --noEmit
  • strict TypeScript check covering MySQL tests and migration script
  • tsdown --config storage/mysql/tsdown.config.ts
  • biome check storage/mysql/src/index.ts
  • MySQL integration suite: 118 tests passed

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates storage/mysql/src/index.ts by casting flatValues to mysql.SqlValue[] in the mysql.format call to resolve type issues, and appends the .js extension to the relative import of KeyvMysqlOptions. There are no review comments, so I have no feedback to provide.

@jaredwray
jaredwray marked this pull request as ready for review July 17, 2026 15:23
@codecov

codecov Bot commented Jul 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (49ed583) to head (88ec574).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #2011   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           55        55           
  Lines         4887      4887           
  Branches       779       784    +5     
=========================================
  Hits          4887      4887           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jaredwray
jaredwray merged commit dc563b6 into main Jul 17, 2026
14 checks passed
@jaredwray
jaredwray deleted the agent/mysql-fix-typescript-errors branch July 17, 2026 15:25
This was referenced Aug 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant