mysql - fix: resolve TypeScript errors - #2011
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates storage/mysql/src/index.ts by casting flatValues to mysql.SqlValue[] in the mysql.format call to resolve type issues, and appends the .js extension to the relative import of KeyvMysqlOptions. There are no review comments, so I have no feedback to provide.
jaredwray
marked this pull request as ready for review
July 17, 2026 15:23
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2011 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 55 55
Lines 4887 4887
Branches 779 784 +5
=========================================
Hits 4887 4887 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setMany()values as mysql2SqlValueentries at the formatting boundary.jsextension required by NodeNext for theKeyvMysqlOptionstype re-exportWhy
A strict TypeScript check failed because the unconstrained bulk-entry generic was not assignable to mysql2's formatter input type, and the relative type export omitted the runtime extension required by NodeNext module resolution. The bundler transpiled successfully, which allowed both errors to go unnoticed.
Impact
This is a type-only compatibility fix. It does not change the generated SQL or runtime adapter behavior.
Validation
tsc -p storage/mysql/tsconfig.json --noEmittsdown --config storage/mysql/tsdown.config.tsbiome check storage/mysql/src/index.ts