mysql - fix: isolate pooled connection lifecycles - #2012
Conversation
There was a problem hiding this comment.
Code Review
This pull request refactors the MySQL storage adapter to use reference-counted connection pool leases, allowing adapters with identical configuration options to share a pool while ensuring pools are not prematurely closed when other adapters are still using them. Feedback was provided to address a potential memory leak in the pool options serialization logic by avoiding a global strong Map for symbol identities and instead serializing symbols using their description or string representation.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2012 +/- ##
===========================================
+ Coverage 99.95% 100.00% +0.04%
===========================================
Files 55 55
Lines 4887 4896 +9
Branches 779 779
===========================================
+ Hits 4885 4896 +11
+ Misses 2 0 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7f9b84313f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
mysql - fix: isolate pooled connection lifecycles