Skip to content

fix: removing the namespace removeKeyPrefix with v6 - #2013

Merged
jaredwray merged 3 commits into
mainfrom
fix-removing-the-namespace-removeKeyPrefix-with-v6
Jul 17, 2026
Merged

fix: removing the namespace removeKeyPrefix with v6#2013
jaredwray merged 3 commits into
mainfrom
fix-removing-the-namespace-removeKeyPrefix-with-v6

Conversation

@jaredwray

@jaredwray jaredwray commented Jul 17, 2026

Copy link
Copy Markdown
Owner

Please check if the PR fulfills these requirements

  • Followed the Contributing and Code of Conduct guidelines.
  • Tests for the changes have been added (for bug fixes/features) with 100% code coverage.

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
fix: removing the namespace removeKeyPrefix with v6

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the removeKeyPrefix method and its usages across various database operations (get, set, delete, has, etc.) in the MySQL storage adapter, ensuring that keys matching or starting with the namespace prefix are not incorrectly stripped. Additionally, new tests are introduced to verify namespace preservation. The review feedback suggests a performance improvement for the delete method by executing the DELETE query directly and checking affectedRows instead of performing an unnecessary preliminary SELECT query.

Comment thread storage/mysql/src/index.ts Outdated
@codecov

codecov Bot commented Jul 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (86b61c8) to head (b8dfeac).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #2013   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           55        55           
  Lines         4896      4878   -18     
  Branches       784       776    -8     
=========================================
- Hits          4896      4878   -18     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jaredwray
jaredwray merged commit 73fd79b into main Jul 17, 2026
14 checks passed
@jaredwray
jaredwray deleted the fix-removing-the-namespace-removeKeyPrefix-with-v6 branch July 17, 2026 16:28
This was referenced Aug 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant