fix: removing the namespace removeKeyPrefix with v6 - #2013
Conversation
There was a problem hiding this comment.
Code Review
This pull request removes the removeKeyPrefix method and its usages across various database operations (get, set, delete, has, etc.) in the MySQL storage adapter, ensuring that keys matching or starting with the namespace prefix are not incorrectly stripped. Additionally, new tests are introduced to verify namespace preservation. The review feedback suggests a performance improvement for the delete method by executing the DELETE query directly and checking affectedRows instead of performing an unnecessary preliminary SELECT query.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2013 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 55 55
Lines 4896 4878 -18
Branches 784 776 -8
=========================================
- Hits 4896 4878 -18 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
fix: removing the namespace removeKeyPrefix with v6