mysql - fix: scheduled cleanup firing - #2017
Conversation
There was a problem hiding this comment.
Code Review
This pull request replaces the native MySQL event scheduler for deleting expired keys with an application-level, unref'd timer. This eliminates the need for special MySQL privileges. The feedback identifies a potential issue where the cleanup timer could be restarted after the adapter has been disconnected, which could lead to failed queries and resource leaks. A guard checking the disconnection state is suggested to prevent this.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2017 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 55 55
Lines 4905 4935 +30
Branches 785 787 +2
=========================================
+ Hits 4905 4935 +30 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1fd4482d84
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
mysql - fix: scheduled cleanup firing