Skip to content

mysql - fix: scheduled cleanup firing - #2017

Merged
jaredwray merged 2 commits into
mainfrom
mysql---fix-scheduled-cleanup-firing
Jul 18, 2026
Merged

mysql - fix: scheduled cleanup firing#2017
jaredwray merged 2 commits into
mainfrom
mysql---fix-scheduled-cleanup-firing

Conversation

@jaredwray

@jaredwray jaredwray commented Jul 18, 2026

Copy link
Copy Markdown
Owner

Please check if the PR fulfills these requirements

  • Followed the Contributing and Code of Conduct guidelines.
  • Tests for the changes have been added (for bug fixes/features) with 100% code coverage.

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
mysql - fix: scheduled cleanup firing

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request replaces the native MySQL event scheduler for deleting expired keys with an application-level, unref'd timer. This eliminates the need for special MySQL privileges. The feedback identifies a potential issue where the cleanup timer could be restarted after the adapter has been disconnected, which could lead to failed queries and resource leaks. A guard checking the disconnection state is suggested to prevent this.

Comment thread storage/mysql/src/index.ts
@codecov

codecov Bot commented Jul 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (f579073) to head (755ee7f).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #2017   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           55        55           
  Lines         4905      4935   +30     
  Branches       785       787    +2     
=========================================
+ Hits          4905      4935   +30     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1fd4482d84

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread storage/mysql/src/index.ts
Comment thread storage/mysql/src/index.ts
@jaredwray
jaredwray merged commit 97fa359 into main Jul 18, 2026
14 checks passed
@jaredwray
jaredwray deleted the mysql---fix-scheduled-cleanup-firing branch July 18, 2026 18:26
This was referenced Aug 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant