Skip to content

mono - chore: upgrade GitHub Actions (breaking) - #2024

Merged
jaredwray merged 1 commit into
mainfrom
chore/github-actions
Aug 2, 2026
Merged

mono - chore: upgrade GitHub Actions (breaking)#2024
jaredwray merged 1 commit into
mainfrom
chore/github-actions

Conversation

@jaredwray

Copy link
Copy Markdown
Owner

Please check if the PR fulfills these requirements

  • Followed the Contributing and Code of Conduct guidelines.
  • Tests for the changes have been added (for bug fixes/features) with 100% code coverage. — n/a, CI configuration change with no source changes.

What kind of change does this PR introduce?

Chore — CI dependency upgrade. Fourth and final dev-phase PR. Follows #2021, #2022, #2023.

Summary

Upgrades actions/setup-node v6 → v7 across all 9 references. The other five actions in this repo are already at their latest major and are untouched.

Changes

  • actions/setup-node@v6@v7 — 9 references across 7 workflow files

Already current, verified against each action's tags and left unchanged:

Action Pinned Latest major
actions/checkout v7 v7 ✅
pnpm/action-setup v6 v6 ✅
codecov/codecov-action v7 v7 ✅
oven-sh/setup-bun v2 v2 ✅
cloudflare/wrangler-action v4 v4 ✅

Existing major-only pin style (@vX) is preserved throughout — no switch to SHA or patch pins.

Verification

  • All 7 workflow files parse as valid YAML after the edit (checked with js-yaml; job/step counts unchanged: 9 setup-node steps before and after)
  • Latest majors confirmed via git ls-remote --tags against each action repository
  • actions/setup-node@v7.0.0 confirmed a stable release, not a pre-release

Breaking notes

actions/setup-node crosses a major. The v7.0.0 notes are terse, but one change is worth your attention because PR CI cannot exercise it:

Removed dummy NODE_AUTH_TOKEN export

I read src/authutil.ts at the v7.0.0 tag to pin down the actual behavior:

  • Both v6 and v7 write the same placeholder line into .npmrc: //registry.npmjs.org/:_authToken=${NODE_AUTH_TOKEN}
  • v6 additionally exported a dummy NODE_AUTH_TOKEN when the user hadn't set one. v7 exports it only if already present in the environment.

This matters for the publish job in release.yaml, which sets registry-url but deliberately sets no token — the step is commented "Uses OIDC only — no token." Under v6 that job ran with a garbage token expanded into .npmrc; under v7 the placeholder expands to empty instead.

My read is this is neutral-to-favorable for OIDC trusted publishing — npm treats an empty _authToken as no credential and proceeds to the OIDC exchange, whereas a bogus token is the kind of thing that earns a 401. But that path only runs on a real release event, so nothing in this PR's checks proves it. Flagging it explicitly so the first release after this merge gets a look rather than a surprise. If you'd rather de-risk it, the publish job's setup-node could stay on v6 independently.


Generated by Claude Code

Upgrade actions/setup-node from v6 to v7 across all 9 references.

The other five actions are already at their latest major and are
unchanged: actions/checkout@v7, pnpm/action-setup@v6,
codecov/codecov-action@v7, oven-sh/setup-bun@v2 and
cloudflare/wrangler-action@v4.

Existing major-only pin style is preserved.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EhFhwXMXeG5bRV8gV61WL3
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@codecov

codecov Bot commented Aug 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (c96ef21) to head (189023f).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #2024   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           55        55           
  Lines         5067      5067           
  Branches       819       821    +2     
=========================================
  Hits          5067      5067           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jaredwray
jaredwray merged commit f3f6c12 into main Aug 2, 2026
15 checks passed
@jaredwray
jaredwray deleted the chore/github-actions branch August 2, 2026 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants