feat: adding SASL support - #54
Conversation
Summary of ChangesHello @jaredwray, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces SASL (Simple Authentication and Security Layer) support by integrating a new Memcached service configured for SASL authentication. This setup provides a dedicated environment for testing and developing features that require secure, authenticated access to Memcached. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #54 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 5 6 +1
Lines 673 977 +304
Branches 138 196 +58
==========================================
+ Hits 673 977 +304 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds SASL support for memcached by introducing a new Docker service for testing. My review focuses on the new Dockerfile and includes several recommendations to improve security and adhere to Docker best practices. Key suggestions include avoiding hardcoded credentials, running the container with a non-privileged user, pinning the base image to a specific version for reproducibility, and optimizing the Dockerfile structure.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bbb836cec6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e8080f0bb1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| socket.removeListener("data", dataHandler); | ||
| resolve(buffer.subarray(0, totalLength)); | ||
| }; | ||
|
|
||
| socket.on("data", dataHandler); |
There was a problem hiding this comment.
binaryRequest adds a fresh data listener for every call without any shared queue or response routing. If two binary* operations run concurrently on the same node (e.g., Promise.all([binaryGet(...), binarySet(...)])), both listeners will receive the same first response, resolve with the wrong data, and the later response will be dropped because both listeners remove themselves. This makes concurrent SASL/binary usage return incorrect results or hang. Consider reusing a single binary response parser with a queue (like the text command queue) or otherwise ensuring requests are strictly serialized.
Useful? React with 👍 / 👎.
1 participant
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
feat: adding SASL support