Fix command menu crash from Bundle.module fatalError - #370
Merged
Conversation
…le (#370) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bundle.modulecall fromSettingsMenuButton.loadTemplateIcon()that was added in Replace settings menu with quick toggle switches #368Bundle.moduleaccessor callsfatalErrorwhen running as a.appbundle because it looks for the resource bundle atThis.app/This_This.bundleinstead ofThis.app/Contents/Resources/This_This.bundleBundle.mainfallbacks already handle icon loading correctly for both debug and app bundlesTest plan
swift run ThisTests— 102 passed, 0 failedmake runand open the command menu — should no longer crash🤖 Generated with Claude Code