Skip to content

Fix voice message not sending when cursor doesn't move - #371

Merged
jasPreMar merged 1 commit into
mainfrom
jasPreMar/fix-no-move-no-send
Apr 6, 2026
Merged

Fix voice message not sending when cursor doesn't move#371
jasPreMar merged 1 commit into
mainfrom
jasPreMar/fix-no-move-no-send

Conversation

@jasPreMar

Copy link
Copy Markdown
Owner

Summary

  • When the user held the invoke hotkey without moving the cursor, recorded a voice message, and released, the message was silently cancelled and never sent
  • Root cause: isCommandKeyVisible only becomes true on cursor movement, and the guard in endCursorFollowInvokeHoldMode cancelled voice + dismissed the panel when it was false
  • Fix: active voice state (.listening or .transcribing) now also satisfies the guard, so voice-only interactions work without requiring cursor movement

Test plan

  • Hold invoke hotkey without moving cursor, record voice message, release — message should send
  • Hold invoke hotkey, move cursor, record voice message, release — still works as before
  • Hold invoke hotkey without moving, release without recording — should still dismiss silently
  • Run swift run ThisTests — 102 tests pass

🤖 Generated with Claude Code

…hold

When the user held the invoke hotkey without moving the cursor, recorded a
voice message, and released, the message was silently cancelled. The guard
in endCursorFollowInvokeHoldMode checked isCommandKeyVisible which only
becomes true on cursor movement. Now voice activity (.listening/.transcribing)
also satisfies the guard so voice-only interactions work without cursor movement.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@jasPreMar
jasPreMar merged commit 5ca0f85 into main Apr 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant