Fix voice message not sending when cursor doesn't move - #371
Merged
Conversation
…hold When the user held the invoke hotkey without moving the cursor, recorded a voice message, and released, the message was silently cancelled. The guard in endCursorFollowInvokeHoldMode checked isCommandKeyVisible which only becomes true on cursor movement. Now voice activity (.listening/.transcribing) also satisfies the guard so voice-only interactions work without cursor movement. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isCommandKeyVisibleonly becomestrueon cursor movement, and the guard inendCursorFollowInvokeHoldModecancelled voice + dismissed the panel when it wasfalse.listeningor.transcribing) now also satisfies the guard, so voice-only interactions work without requiring cursor movementTest plan
swift run ThisTests— 102 tests pass🤖 Generated with Claude Code