Fix voice indicator panel getting stuck after escape in pinned mode - #376
Merged
Conversation
Two bugs fixed: 1. close() non-persistent path didn't call voiceIndicatorPanel.hidePanel(), so escaping via cancelOperation left the voice panel visible with a dead weak-self reference (X button also stopped working). 2. startPinnedFollowMode() didn't cancel prior voice state, so the first tap of a double-tap could leave voice in .transcribing — causing start() to no-op and the indicator to vanish when transcription finished. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Document both bugs fixed in this PR: voice indicator panel not being hidden on close(), and voice state not being reset on pinned follow mode entry. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
close()non-persistent path was missing avoiceIndicatorPanel.hidePanel()call, leaving the panel visible with a dead weak reference so even the X button couldn't dismiss it.startPinnedFollowModeran on the second tap,voiceController.start()was a no-op because voice was still.transcribing. Now cancels prior voice state before starting fresh.Test plan
swift run ThisTests— 102 tests pass