This repository was archived by the owner on Nov 15, 2022. It is now read-only.
Fix #22156: Bug in annotation handling in case of plural annotation handlers#22164
Merged
yaminikb merged 4 commits intojavaee:masterfrom Aug 4, 2017
Merged
Fix #22156: Bug in annotation handling in case of plural annotation handlers#22164yaminikb merged 4 commits intojavaee:masterfrom
yaminikb merged 4 commits intojavaee:masterfrom
Conversation
Member
Author
|
@glassfishrobot Run CI Tests please |
Contributor
|
Starting CI tests run |
Contributor
|
All CI tests successful |
honghzzhang
reviewed
Aug 3, 2017
Collaborator
honghzzhang
left a comment
honghzzhang
left a comment
There was a problem hiding this comment.
The changes look ok to me. Were there any tests failed due to this bug and passed with your change?
Member
Author
|
No, this was just something I have observed while analysing the jms failure. |
honghzzhang
approved these changes
Aug 3, 2017
Collaborator
honghzzhang
left a comment
honghzzhang
left a comment
There was a problem hiding this comment.
In general, at this late point of development lifecycle, I would say only submit changes that are really necessary to maintain the stability of the code base. But the changes look harmless enough so I will approve it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #22156 - Using a plural annotation such as
AdministeredObjectDefinitionsHandlerwould lead to a call to theprocessAnnotationfunction of its singular versionAdministeredObjectDefinitionHandler. During this, theejbProvideris not passed properly leading to a bug in the handling of these annotations.I have added an additional constructor to facilitate this. Changed the code in all plural annotation handlers.