-
Notifications
You must be signed in to change notification settings - Fork 4k
grammar, usage, punctuation corrections for 1-js/01-getting-started #120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
iliakan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thank you. Just a small question.
| ## Let's not argue | ||
|
|
||
| The editors in the lists above are those that me or my friends -- good developers have been using for a long time and are happy with. | ||
| The editors in the lists above are those that either my friends or I -- good developers -- have been using for a long time and are happy with. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's wrong with "me or my friends"?
Anyway I'd like not to point out that I might be a good developer =)
My friends could be, but I shouldn't say such thing about myself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see what you mean about wanting to clarify that 'good developers' is meant to refer only to your friends, rather than your friends and you.
But putting "-- good developers --" aside for a moment, there is a grammatical problem with "me or my friends".
Me" is an object pronoun, but in the sentence above, "me or my friends" is the subject of the verb phrase "have been using". So first we need to change the object pronoun "me" to a subject pronoun: "I or my friends". Furthermore, it is a convention of English usage to place an instance of "I" at the end of a sequence of subjects. So the final refactoring would be "my friends or I".
"My friends or I" is grammatically correct and consistent with common English usage, but in terms of style it is definitely up to you where "-- good developers --" belongs. It could read: "... that either my friends -- good developers -- or I have..."
Let me know how you'd like me to proceed and I will correct the sentence.
Cheers!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about: "...that I or my friends who I consider good developers have been using for a long time" ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That sounds good to me. Just need to add some punctuation. The phrase "who I consider good friends" is an aside, so it should be enclosed in parentheses or dashes. In general, parentheses are used when the aside is incidental, and dashes are used when the aside warrants more attention. The aside does not seem incidental to me, so I would use dashes, but it is a matter of stylistic preference so it is up to you to decide.
In case you are wondering my credentials: I studied rhetoric, communication and English in college, and I am a native English speaker. Thanks for your comments!
|
Thanks a lot, good language is very important, it makes things easy to understand. |
* Update article.md * Update solution.md * Update task.md * Update task.md * Update task.md * Update solution.md * Update task.md * Update solution.md * Update task.md * Update solution.md * Update task.md * Update solution.md * Update task.md * Update article.md * Update solution.md * Update task.md * Update article.md
I've been reading and enjoying this excellent tutorial, but have noticed several errors in grammar, word usage and punctuation. I've avoided altering the meaning of the text, or imposing personal stylistic preferences. All edits are purely of the types described above. I intend to continue editing other articles if these changes suit you. Cheers.