Skip to content

Conversation

@jmbothe
Copy link
Contributor

@jmbothe jmbothe commented Aug 2, 2017

I've been reading and enjoying this excellent tutorial, but have noticed several errors in grammar, word usage and punctuation. I've avoided altering the meaning of the text, or imposing personal stylistic preferences. All edits are purely of the types described above. I intend to continue editing other articles if these changes suit you. Cheers.

Copy link
Member

@iliakan iliakan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you. Just a small question.

## Let's not argue

The editors in the lists above are those that me or my friends -- good developers have been using for a long time and are happy with.
The editors in the lists above are those that either my friends or I -- good developers -- have been using for a long time and are happy with.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's wrong with "me or my friends"?
Anyway I'd like not to point out that I might be a good developer =)
My friends could be, but I shouldn't say such thing about myself.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see what you mean about wanting to clarify that 'good developers' is meant to refer only to your friends, rather than your friends and you.

But putting "-- good developers --" aside for a moment, there is a grammatical problem with "me or my friends".

Me" is an object pronoun, but in the sentence above, "me or my friends" is the subject of the verb phrase "have been using". So first we need to change the object pronoun "me" to a subject pronoun: "I or my friends". Furthermore, it is a convention of English usage to place an instance of "I" at the end of a sequence of subjects. So the final refactoring would be "my friends or I".

"My friends or I" is grammatically correct and consistent with common English usage, but in terms of style it is definitely up to you where "-- good developers --" belongs. It could read: "... that either my friends -- good developers -- or I have..."

Let me know how you'd like me to proceed and I will correct the sentence.

Cheers!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about: "...that I or my friends who I consider good developers have been using for a long time" ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds good to me. Just need to add some punctuation. The phrase "who I consider good friends" is an aside, so it should be enclosed in parentheses or dashes. In general, parentheses are used when the aside is incidental, and dashes are used when the aside warrants more attention. The aside does not seem incidental to me, so I would use dashes, but it is a matter of stylistic preference so it is up to you to decide.

In case you are wondering my credentials: I studied rhetoric, communication and English in college, and I am a native English speaker. Thanks for your comments!

@iliakan iliakan merged commit fcaae24 into javascript-tutorial:master Aug 5, 2017
@iliakan
Copy link
Member

iliakan commented Aug 5, 2017

Thanks a lot, good language is very important, it makes things easy to understand.

athena0304 pushed a commit to athena0304/javascript-tutorial-en that referenced this pull request Aug 21, 2018
* Update article.md

* Update solution.md

* Update task.md

* Update task.md

* Update task.md

* Update solution.md

* Update task.md

* Update solution.md

* Update task.md

* Update solution.md

* Update task.md

* Update solution.md

* Update task.md

* Update article.md

* Update solution.md

* Update task.md

* Update article.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants