fix(domtree): text nodes should render space #35
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
cc @iliakan |
Member
|
I'll look into it. What is incorrect exactly? Just to make sure I understand it. |
Member
Author
Text nodes also have implicit newlines and spaces, and since the article emphasizes these two characters, the text nodes should also be identified by "␣" and "↵".
|
Member
Author
|
Any update? @iliakan |
Member
|
Thanks, fixed! Sorry for the delay, was queued for an in-depth review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to javascript-tutorial/en.javascript.info#2293 (comment), though content is correct, the blank "␣" and "\n" didn't be painted correctly. This PR tries to fix the issue.
The result is as follows:
Related: javascript-tutorial/zh.javascript.info#829 and javascript-tutorial/en.javascript.info#2294.