Skip to content

Update task.md#527

Merged
iliakan merged 2 commits intojavascript-tutorial:masterfrom
Sovgut:patch-1
Aug 31, 2019
Merged

Update task.md#527
iliakan merged 2 commits intojavascript-tutorial:masterfrom
Sovgut:patch-1

Conversation

@Sovgut
Copy link
Contributor

@Sovgut Sovgut commented Aug 22, 2019

У Вас получается противоречие в учебнике по поводу именования переменных 😊

У Вас получается противоречие в учебнике по поводу именования переменных 😊
@javascript-translate-bot javascript-translate-bot added the review needed Review needed, please approve or request changes label Aug 22, 2019
@javascript-translate-bot javascript-translate-bot requested a review from a team August 22, 2019 19:08
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Member

@iliakan iliakan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

А в решении задачи исправлено?

В принципе, я здесь не вижу проблемы, это пример кода, в примерах может быть a, b, c.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

По-русски плиз

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Перевел, сейчас и в решение коммит сделаю

@javascript-translate-bot javascript-translate-bot added changes requested Waiting for changes and /done from PR author and removed review needed Review needed, please approve or request changes labels Aug 29, 2019
@javascript-translate-bot
Copy link
Contributor

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

Перевел текст
@Sovgut
Copy link
Contributor Author

Sovgut commented Aug 30, 2019

Поправил и решение задачи #577
/done

@javascript-translate-bot javascript-translate-bot added review needed Review needed, please approve or request changes and removed changes requested Waiting for changes and /done from PR author labels Aug 30, 2019
@javascript-translate-bot javascript-translate-bot requested a review from a team August 30, 2019 23:23
@javascript-translate-bot javascript-translate-bot added needs +1 One more review needed and removed review needed Review needed, please approve or request changes labels Aug 31, 2019
@iliakan iliakan merged commit a946fcf into javascript-tutorial:master Aug 31, 2019
@iliakan
Copy link
Member

iliakan commented Aug 31, 2019

Ок, спасибо =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs +1 One more review needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Comments