Skip to content

Conversation

@taleksina
Copy link
Contributor

I hope it's not too much. I just wanted to add some Ukrainian vibes to the example. 💙💛

@taleksina
Copy link
Contributor Author

taleksina commented Sep 15, 2023

Closed #551

Copy link
Contributor

@alexandrtovmach alexandrtovmach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but may I ask you to split it up to two PRs? To have one for actual fix #551 and another one with your changes to the article. It'll be really helpful to track changes.

Current PR contains a "bit more" than actual fix, and require some discussion.

@javascript-translate-bot
Copy link
Contributor

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@taleksina
Copy link
Contributor Author

/done

Copy link
Collaborator

@tarasyyyk tarasyyyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@taleksina, щиро вдячні за переклад!
Чудове перефразування, мені сподобалося :)

@tarasyyyk tarasyyyk merged commit 5033b71 into javascript-tutorial:master Aug 29, 2024
@tarasyyyk
Copy link
Collaborator

@all-contributors add @taleksina for translation.

@allcontributors
Copy link
Contributor

@tarasyyyk

I've put up a pull request to add @taleksina! 🎉

@taleksina
Copy link
Contributor Author

@tarasyyyk @alexandrtovmach
Thank you, guys! Now, you have inspired me to go on and make the UA tutorial rocks even more.

@taleksina taleksina deleted the mavka branch September 4, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants