-
Notifications
You must be signed in to change notification settings - Fork 183
Update article.md & all SVGs #550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Closed #551 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but may I ask you to split it up to two PRs? To have one for actual fix #551 and another one with your changes to the article. It'll be really helpful to track changes.
Current PR contains a "bit more" than actual fix, and require some discussion.
|
Please make the requested changes. After it, add a comment "/done". |
|
/done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@taleksina, щиро вдячні за переклад!
Чудове перефразування, мені сподобалося :)
|
@all-contributors add @taleksina for translation. |
|
I've put up a pull request to add @taleksina! 🎉 |
|
@tarasyyyk @alexandrtovmach |
I hope it's not too much. I just wanted to add some Ukrainian vibes to the example. 💙💛