Skip to content

split map-set apart from weakmap-weakset,参考上游将该章节分为俩部分(中文版已同步至最新),由于更改了章节序号,导致看起来更改了很多文件,事实上只是将 1-js/05-data-types/07-map-set-weakmap-weakset下的文件分离开了,原来的08章变成09章,09变成10章,以此类推#530

Merged
leviding merged 7 commits intojavascript-tutorial:masterfrom
liguonan888:master
Nov 25, 2019

Conversation

@liguonan888
Copy link
Contributor

目标章节: 1-js/05-data-types/07-map-set-weakmap-weakset

当前上游最新 commit:b11005ccfda75dc9409e0a0e725e20d4dcaeab7d

所做更改如下:

文件名 参考上游 commit 更改(理由)
07-map-set-weakmap-weakset下的所有文件(夹) b11005c split map-set apart from weakmap-weakset

@leviding
Copy link
Member

很赞,感谢 PR。但是存在点小问题,如下图:

image

文件路径修改后,04 和 05 应该分别变为 01 和 02。

我先 merge 本 PR,之后再修改。

@leviding leviding merged commit 28cc377 into javascript-tutorial:master Nov 25, 2019
@leviding leviding added DONE and removed needs +1 labels Nov 25, 2019
@leviding
Copy link
Member

欢迎继续提交更多 PR 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants