fix(#298): add go install instructions to bundled notion-cli plugin - #369
fix(#298): add go install instructions to bundled notion-cli plugin#369javimosch wants to merge 1 commit into
Conversation
Add the primary `go install github.com/4ier/notion-cli@latest` method from the issue to plugin.json, install-guidance.json, and the quickstart skill. Homebrew and npm remain documented as alternatives. Fixes #298 Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
📝 WalkthroughWalkthroughNotion CLI installation guidance now prioritizes ChangesNotion CLI installation
Estimated code review effort: 1 (Trivial) | ~3 minutes Possibly related issues Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@plugins/notion-cli/install-guidance.json`:
- Around line 6-7: Update the Go installation flow in
plugins/notion-cli/install-guidance.json:6-7 to add the Go binary directory to
PATH before verification and install_steps, covering GOBIN and the default
$HOME/go/bin location. Update the related version/passthrough help at
plugins/notion-cli/plugin.json:14-14, plugin.json:33-33, and
plugin.json:233-233, plus the quickstart installation instructions at
plugins/notion-cli/skills/quickstart/SKILL.md:61-63, to document this PATH setup
so which notion, notion --version, and passthrough calls can locate the
installed binary.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: c1f83b80-748b-46eb-8315-6d7bf5a09db9
📒 Files selected for processing (3)
plugins/notion-cli/install-guidance.jsonplugins/notion-cli/plugin.jsonplugins/notion-cli/skills/quickstart/SKILL.md
| "go install github.com/4ier/notion-cli@latest", | ||
| "Verify: notion --version", |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "Files:"
git ls-files | rg '(^|/)plugins/notion-cli/|notion-cli' || true
echo
echo "Relevant file sections:"
for f in plugins/notion-cli/install-guidance.json plugins/notion-cli/plugin.json plugins/notion-cli/skills/quickstart/SKILL.md; do
if [ -f "$f" ]; then
echo "--- $f ---"
wc -l "$f"
sed -n '1,90p' "$f"
if [ "$f" = plugins/notion-cli/plugin.json ]; then
echo "--- plugin.json lines 220-242 ---"
sed -n '220,242p' "$f"
fi
else
echo "missing $f"
fi
done
echo
echo "Search notion-cli install/help references:"
rg -n "go install github\.com/4ier/notion-cli|notion --version|notion auth login|missingDependencyHelp|install_steps" plugins/notion-cli .github plugins 2>/dev/null | head -200Repository: javimosch/supercli
Length of output: 32633
🌐 Web query:
Go installation PATH GOPATH/bin default GOBIN documentation
💡 Result:
When you run the go install command, Go compiles and installs executables into a specific directory controlled by the GOBIN and GOPATH environment variables [1][2]. The installation location is determined as follows: 1. If the GOBIN environment variable is set, binaries are installed into the directory specified by GOBIN [3][4]. GOBIN must be an absolute path [4]. 2. If GOBIN is not set, binaries are installed into the bin subdirectory of the first directory listed in the GOPATH environment variable [3][5]. 3. If neither GOBIN nor GOPATH is set, Go defaults to using $HOME/go/bin on Unix systems or %USERPROFILE%\go\bin on Windows [1][6][4]. To make these installed binaries easily executable from your command line, it is standard practice to add the binary installation directory (e.g., $HOME/go/bin) to your system PATH environment variable [3][7]. You can check your current configuration by running the command go env [3]. If you wish to change the default binary installation location, you can update GOBIN using: go env -w GOBIN=/your/custom/path/bin [3][7] Or, you can adjust the GOPATH workspace location to change where the default bin directory is located [6]. Note that while modern Go development primarily uses Go modules for dependency management, the GOPATH variable remains relevant for determining these default installation and cache locations [2][8][4].
Citations:
- 1: https://pkg.go.dev/cmd/go
- 2: https://pkg.go.dev/cmd/go@go1.26.5
- 3: https://go.dev/doc/code
- 4: https://manpages.debian.org/bookworm/golang-go/go-path.7.en.html
- 5: https://manpages.debian.org/unstable/golang-go/go-install.1.en.html
- 6: https://go.dev/wiki/SettingGOPATH
- 7: https://go.dev/doc/tutorial/compile-install
- 8: https://go.dev/wiki/GOPATH
Make Go installation output reachable by SuperCLI.
go install writes the binary to GOBIN, or $HOME/go/bin when GOBIN is unset. Add the installation directory to PATH before verification and install_steps, and document it in version/passthrough help and quickstart installation. If users omit this step, verify: which notion, notion --version, and notion passthrough calls can fail after installation succeeds.
📍 Affects 3 files
plugins/notion-cli/install-guidance.json#L6-L7(this comment)plugins/notion-cli/plugin.json#L14-L14plugins/notion-cli/plugin.json#L33-L33plugins/notion-cli/plugin.json#L233-L233plugins/notion-cli/skills/quickstart/SKILL.md#L61-L63
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@plugins/notion-cli/install-guidance.json` around lines 6 - 7, Update the Go
installation flow in plugins/notion-cli/install-guidance.json:6-7 to add the Go
binary directory to PATH before verification and install_steps, covering GOBIN
and the default $HOME/go/bin location. Update the related version/passthrough
help at plugins/notion-cli/plugin.json:14-14, plugin.json:33-33, and
plugin.json:233-233, plus the quickstart installation instructions at
plugins/notion-cli/skills/quickstart/SKILL.md:61-63, to document this PATH setup
so which notion, notion --version, and passthrough calls can locate the
installed binary.
|
🤖 Escalated to CEO: https://github.com/javimosch/am-fleet/issues/48 The rebaser could not resolve conflicts automatically. Reply on the issue above to unblock this PR. |
1 participant
Automated maintenance run by automaintainer.
Focus: == ASSIGNED OBJECTIVE ==
Fix GitHub issue #298 ONLY: Add 4ier/notion-cli as a bundled plugin in SuperCLI. PR title MUST reference #298.
OPEN PR AWARENESS (secondary — do not replace the ASSIGNED OBJECTIVE):
These open pull requests are already open and awaiting review. Do NOT start UNRELATED work on the files they touch. If your ASSIGNED OBJECTIVE requires editing one of those files, complete the objective anyway. Never abandon the objective to pick a different GitHub issue just to avoid overlap.
touches: plugins/notion-cli/install-guidance.json, plugins/notion-cli/plugin.json, plugins/notion-cli/skills/quickstart/SKILL.md
touches: plugins/notion-cli/install-guidance.json, plugins/notion-cli/plugin.json, plugins/notion-cli/skills/quickstart/SKILL.md
touches: plugins/notion-cli/install-guidance.json, plugins/notion-cli/plugin.json, plugins/notion-cli/skills/quickstart/SKILL.md
run <plugin> <resource> <action>one-shot command #365 (am/am-f17c27-dkdoeotqzvn8-3120cd1a): fix(feat:sc run <plugin> <action>— one-shot discover+install+execute #335): implementrun <plugin> <resource> <action>one-shot commandtouches: tests/run-command.test.js, cli/help-json.js, cli/help.js, cli/run.js, cli/supercli.js
touches: .github/workflows/sc-machin-release.yml, README.md, supercli-machin-cli/README.md, supercli-machin-cli/install.sh
Branch:
am/am-f17c27-dkfgj4w7jxmc-e50a95d1Diff:
Summary by CodeRabbit