fix(installer): re-run chown warns instead of aborting on partial failure

[jaylfc]

Audit follow-up to #1839. The re-run ownership chown -R runs under set -euo pipefail, so a partial failure (immutable file, read-only mount) aborts the whole installer. Wrap it in a warn like the sibling set_data_dir_ownership does, and let the subsequent git reset surface any real ownership problem. bash -n clean.

Summary by CodeRabbit

• Bug Fixes
  • Improved installation reliability when updating an existing repository.
  • Partial ownership-adjustment failures now generate a warning while allowing the update process to continue.

[qodo-code-review]

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 1aa86b74-5cc4-4cab-9798-a8ded27a660c

📥 Commits

Reviewing files that changed from the base of the PR and between 5d5dec3 and 01fe921.

📒 Files selected for processing (1)

• scripts/install-server.sh

---

📝 Walkthrough

Walkthrough

The installer’s existing-repository update path now treats recursive ownership normalization failures as warnings, allowing subsequent unprivileged Git fetch and reset operations to continue.

Changes

Installer update recovery

Layer / File(s)	Summary
Tolerate recursive ownership failure scripts/install-server.sh	Recursive chown failures now emit a warning instead of aborting the installer, while the existing git fetch and git reset steps remain unchanged.

Estimated code review effort: 2 (Simple) | ~5 minutes

Possibly related PRs

• jaylfc/taOS#768: Both changes modify repository ownership handling in the existing-install update path.
• jaylfc/taOS#1839: Both changes modify recursive ownership normalization before Git update operations.
• jaylfc/taOS#1840: Both changes adjust recursive ownership normalization in the installer update path.

Suggested reviewers: hognek

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the installer change: partial chown failures now warn instead of aborting during rerun.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/installer-chown-warn

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[gitar-bot]

Important

You are using the Gitar free plan. Upgrade to unlock code review, CI analysis, auto-apply, custom automations, and more.

_Gitar

[kilo-code-bot]

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (1 files)

• scripts/install-server.sh

---

_{Reviewed by hy3:free · Input: 35.5K · Output: 1.4K · Cached: 96.6K}