-
-
Notifications
You must be signed in to change notification settings - Fork 36
taOStalk s1: content_blocks types + renderContent dispatcher #2154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -158,6 +158,44 @@ export function resolveAuthorDisplayState( | |
| return "removed"; | ||
| } | ||
|
|
||
| interface TextContentBlock { | ||
| kind: "text"; | ||
| text: string; | ||
| } | ||
|
|
||
| interface ThinkingContentBlock { | ||
| kind: "thinking"; | ||
| text: string; | ||
| collapsed?: boolean; | ||
| } | ||
|
|
||
| interface ToolCallContentBlock { | ||
| kind: "tool_call"; | ||
| call_id: string; | ||
| name: string; | ||
| input_preview?: string; | ||
| status: "running" | "done" | "error"; | ||
| result_preview?: string; | ||
| } | ||
|
|
||
| interface StatusContentBlock { | ||
| kind: "status"; | ||
| text: string; | ||
| } | ||
|
|
||
| /** | ||
| * Structured message content for taOStalk session turns. | ||
| * Known kinds are handled by dedicated block components (separate cards); | ||
| * any unrecognized kind falls through to the unknown-block fallback in | ||
| * renderContent, which is the slice-2 seam. | ||
| */ | ||
| export type ContentBlock = | ||
| | TextContentBlock | ||
| | ThinkingContentBlock | ||
| | ToolCallContentBlock | ||
| | StatusContentBlock | ||
| | { kind: string; [key: string]: unknown }; | ||
|
|
||
| interface Message { | ||
| id: string; | ||
| channel_id: string; | ||
|
|
@@ -167,6 +205,7 @@ interface Message { | |
| /** Parent message id when this message is a thread reply. */ | ||
| thread_id?: string; | ||
| content_type?: "text" | "canvas" | string; | ||
| content_blocks?: ContentBlock[]; | ||
| metadata?: { | ||
| canvas_id?: string; | ||
| canvas_url?: string; | ||
|
|
@@ -217,7 +256,32 @@ export function relativeTime(ts: number | string, nowMs: number = Date.now()): s | |
| return new Date(ms).toLocaleTimeString(undefined, { hour: "2-digit", minute: "2-digit" }); | ||
| } | ||
|
|
||
| export function renderContent(text: string) { | ||
| /** | ||
| * Dispatch a single content block to its renderer. Known kinds (text, | ||
| * thinking, tool_call, status) are dispatched to dedicated block components | ||
| * in separate cards; until those land, they fall through to the unknown | ||
| * fallback. This is the slice-2 seam: add a case per kind and return the | ||
| * block component. | ||
| */ | ||
| function renderContentBlock(block: ContentBlock, index: number): React.ReactElement { | ||
| switch (block.kind) { | ||
| case "text": | ||
| case "thinking": | ||
| case "tool_call": | ||
| case "status": | ||
| default: | ||
| return ( | ||
| <div key={`block-${index}`} className="text-shell-text-tertiary text-[12px]"> | ||
| unsupported block: {block.kind} | ||
| </div> | ||
| ); | ||
| } | ||
| } | ||
|
|
||
| export function renderContent(text: string, content_blocks?: ContentBlock[]) { | ||
| if (content_blocks && content_blocks.length > 0) { | ||
| return content_blocks.map((block, i) => renderContentBlock(block, i)); | ||
| } | ||
|
Comment on lines
+266
to
+284
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 1. Blocks hide real content renderContent() takes the content_blocks path whenever it is non-empty, but renderContentBlock() currently renders every kind (including "text") as an "unsupported block" placeholder. Any message that arrives with populated content_blocks will therefore display placeholders instead of its actual content. Agent Prompt
|
||
| // Split on fenced code blocks first, then apply inline markdown to non-code segments. | ||
| const result: (string | React.ReactElement)[] = []; | ||
| const fenceRegex = /```(?:[^\n]*)?\n([\s\S]*?)```/g; | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2. Catch-all block overlaps kinds
🐞 Bug⚙ MaintainabilityContentBlock includes a { kind: string; ... } catch-all member that overlaps all known kind literals, so malformed shapes like { kind: 'text' } can type-check as ContentBlock. This weakens compile-time guarantees for future per-kind renderers and encourages scattered runtime validation.Agent Prompt
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools