fix(lists): call _get_next_position when add_entry position is None

tests/projects/test_lists_store.py

@@ -0,0 +1,252 @@
+import time
+
+import pytest
+import pytest_asyncio
+
+from tinyagentos.projects.lists_store import ProjectListsStore, ProjectListEntriesStore
+
+
+@pytest_asyncio.fixture
+async def lists_store(tmp_path):
+    s = ProjectListsStore(tmp_path / "lists.db")
+    await s.init()
+    yield s
+    await s.close()
+
+
+@pytest_asyncio.fixture
+async def entries_store(tmp_path):
+    s = ProjectListEntriesStore(tmp_path / "entries.db")
+    await s.init()
+    yield s
+    await s.close()
+
+
+@pytest.mark.asyncio
+async def test_create_list_assigns_lst_prefix(lists_store):
+    l = await lists_store.create_list(
+        project_id="prj-1", title="Shopping", created_by="user-1"
+    )
+    assert l["id"].startswith("lst-")
+    assert l["project_id"] == "prj-1"
+    assert l["title"] == "Shopping"
+    assert l["status"] == "active"
+    assert l["created_by"] == "user-1"
+    assert l["created_at"] == l["updated_at"]
+
+
+@pytest.mark.asyncio
+async def test_get_list_returns_none_for_missing(lists_store):
+    assert await lists_store.get_list("lst-missing") is None
+
+
+@pytest.mark.asyncio
+async def test_list_lists_scoped_to_project(lists_store):
+    await lists_store.create_list(project_id="prj-1", title="A", created_by="u")
+    await lists_store.create_list(project_id="prj-2", title="B", created_by="u")
+    items = await lists_store.list_lists("prj-1")
+    assert len(items) == 1
+    assert items[0]["title"] == "A"
+
+
+@pytest.mark.asyncio
+async def test_update_list_changes_fields(lists_store):
+    l = await lists_store.create_list(
+        project_id="prj-1", title="Original", created_by="u"
+    )
+    updated = await lists_store.update_list(l["id"], title="Renamed", status="archived")
+    assert updated["title"] == "Renamed"
+    assert updated["status"] == "archived"
+    assert updated["updated_at"] > l["updated_at"]
+
+
+@pytest.mark.asyncio
+async def test_delete_list(lists_store):
+    l = await lists_store.create_list(
+        project_id="prj-1", title="Gone", created_by="u"
+    )
+    assert await lists_store.delete_list(l["id"]) is True
+    assert await lists_store.get_list(l["id"]) is None
+
+
+@pytest.mark.asyncio
+async def test_delete_nonexistent_list(lists_store):
+    assert await lists_store.delete_list("lst-missing") is False
+
+
+@pytest.mark.asyncio
+async def test_add_entry_then_get_entry_round_trip(entries_store):
+    e = await entries_store.add_entry(
+        list_id="lst-1",
+        project_id="prj-1",
+        text="Buy milk",
+        original_text="Buy milk",
+        author_kind="agent",
+        author_id="agent-1",
+        position=0,
+    )
+    assert e["id"].startswith("ent-")
+    assert e["list_id"] == "lst-1"
+    assert e["project_id"] == "prj-1"
+    assert e["text"] == "Buy milk"
+    assert e["original_text"] == "Buy milk"
+    assert e["position"] == 0
+
+    again = await entries_store.get_entry(e["id"])
+    assert again["id"] == e["id"]
+    assert again["text"] == "Buy milk"
+    assert again["original_text"] == "Buy milk"
+
+
+@pytest.mark.asyncio
+async def test_list_entries_ordered_by_position(entries_store):
+    await entries_store.add_entry(
+        list_id="lst-1", project_id="prj-1", text="B", original_text="B",
+        author_kind="agent", author_id="agent-1", position=1,
+    )
+    await entries_store.add_entry(
+        list_id="lst-1", project_id="prj-1", text="A", original_text="A",
+        author_kind="agent", author_id="agent-1", position=0,
+    )
+    await entries_store.add_entry(
+        list_id="lst-1", project_id="prj-1", text="C", original_text="C",
+        author_kind="agent", author_id="agent-1", position=2,
+    )
+    items = await entries_store.list_entries(project_id="prj-1", list_id="lst-1")
+    assert [item["text"] for item in items] == ["A", "B", "C"]
+    assert [item["position"] for item in items] == [0, 1, 2]
+
+
+@pytest.mark.asyncio
+async def test_update_entry_preserves_original_text(entries_store):
+    e = await entries_store.add_entry(
+        list_id="lst-1",
+        project_id="prj-1",
+        text="Get groceries",
+        original_text="Get groceries",
+        author_kind="agent",
+        author_id="agent-1",
+    )
+    updated = await entries_store.update_entry(e["id"], text="Get groceries tidied")
+    assert updated is not None
+    assert updated["text"] == "Get groceries tidied"
+    assert updated["original_text"] == "Get groceries"
+
+
+@pytest.mark.asyncio
+async def test_delete_entry(entries_store):
+    e = await entries_store.add_entry(
+        list_id="lst-1",
+        project_id="prj-1",
+        text="Buy milk",
+        original_text="Buy milk",
+        author_kind="agent",
+        author_id="agent-1",
+    )
+    assert await entries_store.delete_entry(e["id"]) is True
+    assert await entries_store.get_entry(e["id"]) is None
+
+
+@pytest.mark.asyncio
+async def test_delete_nonexistent_entry(entries_store):
+    assert await entries_store.delete_entry("ent-missing") is False
+
+
+@pytest.mark.asyncio
+async def test_reorder_entries(entries_store):
+    a = await entries_store.add_entry(
+        list_id="lst-1", project_id="prj-1", text="A", original_text="A",
+        author_kind="agent", author_id="agent-1", position=0,
+    )
+    b = await entries_store.add_entry(
+        list_id="lst-1", project_id="prj-1", text="B", original_text="B",
+        author_kind="agent", author_id="agent-1", position=1,
+    )
+    c = await entries_store.add_entry(
+        list_id="lst-1", project_id="prj-1", text="C", original_text="C",
+        author_kind="agent", author_id="agent-1", position=2,
+    )
+    await entries_store.reorder_entries(
+        project_id="prj-1",
+        entries=[
+            {"id": c["id"], "position": 0},
+            {"id": a["id"], "position": 1},
+            {"id": b["id"], "position": 2},
+        ],
+    )
+    items = await entries_store.list_entries(project_id="prj-1", list_id="lst-1")
+    assert [item["text"] for item in items] == ["C", "A", "B"]
+
+
+@pytest.mark.asyncio
+async def test_get_next_position_returns_sequential_values(entries_store):
+    a = await entries_store.add_entry(
+        list_id="lst-1", project_id="prj-1", text="A", original_text="A",
+        author_kind="agent", author_id="agent-1", position=0,
+    )
+    assert await entries_store._get_next_position("prj-1", "lst-1") == 1
+
+    b = await entries_store.add_entry(
+        list_id="lst-1", project_id="prj-1", text="B", original_text="B",
+        author_kind="agent", author_id="agent-1", position=1,
+    )
+    assert await entries_store._get_next_position("prj-1", "lst-1") == 2
+
+    await entries_store.add_entry(
+        list_id="lst-1", project_id="prj-1", text="C", original_text="C",
+        author_kind="agent", author_id="agent-1", position=2,
+    )
+    assert await entries_store._get_next_position("prj-1", "lst-1") == 3
+
+
+@pytest.mark.asyncio
+async def test_list_entries_scoped_to_list_and_status(entries_store):
+    await entries_store.add_entry(
+        list_id="lst-1", project_id="prj-1", text="A", original_text="A",
+        author_kind="agent", author_id="agent-1",
+    )
+    await entries_store.add_entry(
+        list_id="lst-2", project_id="prj-1", text="B", original_text="B",
+        author_kind="agent", author_id="agent-1",
+    )
+    c = await entries_store.add_entry(
+        list_id="lst-1", project_id="prj-1", text="C", original_text="C",
+        author_kind="agent", author_id="agent-1",
+    )
+    await entries_store.update_entry(c["id"], status="closed")
+    assert len(await entries_store.list_entries(project_id="prj-1", list_id="lst-1")) == 2
+    assert len(await entries_store.list_entries(project_id="prj-1", status="closed")) == 1
+
+
+@pytest.mark.asyncio
+async def test_add_entries_without_positions_gets_ascending(entries_store):
+    """Adding entries without explicit positions should auto-assign distinct
+    ascending positions via _get_next_position (not flat 0s)."""
+    e1 = await entries_store.add_entry(
+        list_id="lst-1",
+        project_id="prj-1",
+        text="First",
+        original_text="First",
+        author_kind="agent",
+        author_id="agent-1",
+    )
+    e2 = await entries_store.add_entry(
+        list_id="lst-1",
+        project_id="prj-1",
+        text="Second",
+        original_text="Second",
+        author_kind="agent",
+        author_id="agent-1",
+    )
+    e3 = await entries_store.add_entry(
+        list_id="lst-1",
+        project_id="prj-1",
+        text="Third",
+        original_text="Third",
+        author_kind="agent",
+        author_id="agent-1",
+    )
+    positions = [e["position"] for e in (e1, e2, e3)]
+    assert positions == [0, 1, 2], (
+        f"Expected [0, 1, 2] but got {positions}"
+    )

tinyagentos/projects/ids.py

@@ -1,7 +1,7 @@
 from __future__ import annotations
 import secrets
 
-ID_PREFIXES = ("prj", "tsk", "cmt", "rel", "cve", "dec", "doc", "ent", "rev", "cs", "rtn", "elm")
+ID_PREFIXES = ("prj", "tsk", "cmt", "rel", "cve", "dec", "doc", "ent", "lst", "rev", "cs", "rtn", "elm")
 _ALPHABET = "abcdefghijklmnopqrstuvwxyz234567"