Skip to content

fix(messages): make conversation text selectable - #457

Merged
jaylfc merged 1 commit into
masterfrom
fix/messages-text-selection
May 30, 2026
Merged

fix(messages): make conversation text selectable#457
jaylfc merged 1 commit into
masterfrom
fix/messages-text-selection

Conversation

@jaylfc

@jaylfc jaylfc commented May 30, 2026

Copy link
Copy Markdown
Owner

Problem

Reported in #455 (@johny-mnemonic): text in the Messages app can't be selected — neither your own messages nor agent replies.

Root cause

Most app shells in the desktop deliberately set `select-none` for a native-OS feel (Models, Providers, Library, Channels, …). The Messages app relied on the absence of that class to stay selectable, rather than opting in explicitly. That's fragile — any `select-none` added to an ancestor silently makes conversation text unselectable, and it leaves intent unclear.

Fix

Add `select-text` to the message-list container so message content is selectable by design and resilient to future shell changes. One line + an explanatory comment; device-agnostic (same content component on desktop and mobile).

Verification

  • `tsc -b` clean.
  • Visual confirmation (selecting/copying message text) to be done on a running instance.

Closes #455

Summary by CodeRabbit

  • Bug Fixes
    • Users can now select and copy text from conversations in the Messages app. Text selection is now enabled in the message list, allowing you to highlight and copy conversation text as needed.

Review Change Stack

The Messages list relied on the absence of a select-none class to stay
selectable, but the rest of the desktop shell sets select-none widely for
the native-OS feel. Opt the message list back in explicitly with select-text
so users can copy their own and agent messages, and so a future select-none
on an ancestor can't silently regress it.

Closes #455
@coderabbitai

coderabbitai Bot commented May 30, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 4475be99-5f33-48ae-b399-2901858a1718

📥 Commits

Reviewing files that changed from the base of the PR and between 2184d7e and 228c56a.

📒 Files selected for processing (1)
  • desktop/src/apps/MessagesApp.tsx

📝 Walkthrough

Walkthrough

This PR enables text selection in the Messages app message list. The container wrapping the conversation is updated to apply the select-text CSS class, explicitly opting into user text selection and overriding the default select-none behavior inherited from the app shell. A clarifying comment documents this choice.

Changes

Message Text Selection

Layer / File(s) Summary
Enable text selection in message list
desktop/src/apps/MessagesApp.tsx
The message list container is updated with the select-text class to allow users to select and copy conversation text, with an inline comment clarifying that this overrides the app shell's default select-none behavior.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A tiny tweak, so light and small,
Just text that users now can haul,
Select and copy, message by line—
In conversations, words now shine!
No more locked words, the rabbits say,
Let chatter flow and text convey. ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix(messages): make conversation text selectable' directly and clearly summarizes the main change—enabling text selection in the Messages app.
Linked Issues check ✅ Passed The PR successfully addresses issue #455 by adding select-text styling to make conversation text selectable, restoring both user message and agent reply selection.
Out of Scope Changes check ✅ Passed All changes are directly scoped to the Messages app text selection issue; no unrelated modifications are present in the changeset.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/messages-text-selection

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@kilo-code-bot

kilo-code-bot Bot commented May 30, 2026

Copy link
Copy Markdown

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (1 files)
  • desktop/src/apps/MessagesApp.tsx

Reviewed by nemotron-3-super-120b-a12b-20230311:free · 1,456,055 tokens

@jaylfc
jaylfc merged commit f27c49d into master May 30, 2026
8 checks passed
@jaylfc
jaylfc deleted the fix/messages-text-selection branch May 30, 2026 18:41
@github-project-automation github-project-automation Bot moved this from Todo to Done in TinyAgentOS Roadmap May 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

Unable to select text in Messages app

1 participant