fix(messages): make conversation text selectable - #457
Conversation
The Messages list relied on the absence of a select-none class to stay selectable, but the rest of the desktop shell sets select-none widely for the native-OS feel. Opt the message list back in explicitly with select-text so users can copy their own and agent messages, and so a future select-none on an ancestor can't silently regress it. Closes #455
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR enables text selection in the Messages app message list. The container wrapping the conversation is updated to apply the ChangesMessage Text Selection
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (1 files)
Reviewed by nemotron-3-super-120b-a12b-20230311:free · 1,456,055 tokens |
Problem
Reported in #455 (@johny-mnemonic): text in the Messages app can't be selected — neither your own messages nor agent replies.
Root cause
Most app shells in the desktop deliberately set `select-none` for a native-OS feel (Models, Providers, Library, Channels, …). The Messages app relied on the absence of that class to stay selectable, rather than opting in explicitly. That's fragile — any `select-none` added to an ancestor silently makes conversation text unselectable, and it leaves intent unclear.
Fix
Add `select-text` to the message-list container so message content is selectable by design and resilient to future shell changes. One line + an explanatory comment; device-agnostic (same content component on desktop and mobile).
Verification
Closes #455
Summary by CodeRabbit