fix(widgets): GreetingWidget uses lucide icons instead of emoji - #481
Conversation
The evening greeting emoji (U+1F306) renders as a tofu/box glyph on iOS where the system font lacks it. Swap all four time-of-day emoji for lucide SVG icons (Sun / CloudSun / Sunset / Moon) — font-independent and consistent with the rest of the app's icon system. Adds a test asserting the right SVG renders per time of day and that the broken glyph is gone.
|
Warning Review limit reached
More reviews will be available in 15 minutes and 27 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (2 files)
Reviewed by nemotron-3-super-120b-a12b-20230311:free · 285,856 tokens |
Fixes the broken "Good evening" icon (one of the deferred UI bugs). The evening emoji (U+1F306 🌆) renders as a tofu/box glyph on iOS where the font lacks it. All four time-of-day emoji are now lucide SVG icons (
Sun/CloudSun/Sunset/Moon) — font-independent and consistent with the app's existing lucide-based icon system.Includes a vitest test asserting the correct SVG renders per time of day and that the broken glyph no longer appears.
tsc -bclean.Left for your review since it's a visual change — worth an eyeball on the widget at the different sizes (s/m/l tiers).