Skip to content

fix(widgets): GreetingWidget uses lucide icons instead of emoji - #481

Merged
jaylfc merged 3 commits into
masterfrom
fix/greeting-widget-lucide-icon
May 31, 2026
Merged

fix(widgets): GreetingWidget uses lucide icons instead of emoji#481
jaylfc merged 3 commits into
masterfrom
fix/greeting-widget-lucide-icon

Conversation

@jaylfc

@jaylfc jaylfc commented May 31, 2026

Copy link
Copy Markdown
Owner

Fixes the broken "Good evening" icon (one of the deferred UI bugs). The evening emoji (U+1F306 🌆) renders as a tofu/box glyph on iOS where the font lacks it. All four time-of-day emoji are now lucide SVG icons (Sun / CloudSun / Sunset / Moon) — font-independent and consistent with the app's existing lucide-based icon system.

Includes a vitest test asserting the correct SVG renders per time of day and that the broken glyph no longer appears. tsc -b clean.

Left for your review since it's a visual change — worth an eyeball on the widget at the different sizes (s/m/l tiers).

The evening greeting emoji (U+1F306) renders as a tofu/box glyph on iOS where
the system font lacks it. Swap all four time-of-day emoji for lucide SVG icons
(Sun / CloudSun / Sunset / Moon) — font-independent and consistent with the
rest of the app's icon system. Adds a test asserting the right SVG renders per
time of day and that the broken glyph is gone.
@coderabbitai

coderabbitai Bot commented May 31, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@jaylfc, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 15 minutes and 27 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 99c82dbc-4792-413a-861a-9501788b3410

📥 Commits

Reviewing files that changed from the base of the PR and between 335bec8 and 07e2c47.

📒 Files selected for processing (2)
  • desktop/src/components/widgets/GreetingWidget.tsx
  • desktop/src/components/widgets/__tests__/GreetingWidget.test.tsx
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/greeting-widget-lucide-icon

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@kilo-code-bot

kilo-code-bot Bot commented May 31, 2026

Copy link
Copy Markdown

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (2 files)
  • desktop/src/components/widgets/GreetingWidget.tsx
  • desktop/src/components/widgets/tests/GreetingWidget.test.tsx

Reviewed by nemotron-3-super-120b-a12b-20230311:free · 285,856 tokens

@jaylfc
jaylfc merged commit e82eddb into master May 31, 2026
6 checks passed
@jaylfc
jaylfc deleted the fix/greeting-widget-lucide-icon branch May 31, 2026 15:19
@github-project-automation github-project-automation Bot moved this from Todo to Done in TinyAgentOS Roadmap May 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

1 participant