Skip to content

chore: promote dev to master (installer re-run ownership fix) - #769

Merged
jaylfc merged 1 commit into
masterfrom
dev
Jun 11, 2026
Merged

chore: promote dev to master (installer re-run ownership fix)#769
jaylfc merged 1 commit into
masterfrom
dev

Conversation

@jaylfc

@jaylfc jaylfc commented Jun 11, 2026

Copy link
Copy Markdown
Owner

Promotes #768 to master: the installer re-run update path dropped to running git as root inside the taos-owned tree, which both tripped git's dubious-ownership check (blocking the sudo re-run recovery path from #765) and was a privilege-escalation vector. Now drops to the repo owner for fetch/reset. Fixes #765.

…e taos chown (#768)

* fix(install): scope a safe.directory exception for the re-run update path (#765)

* fix(install): drop to the repo owner for the re-run update instead of overriding git ownership trust

Running git as root inside a taos-owned tree (so a planted .git/config or
hook could execute as root) is the privilege-escalation the dubious-ownership
check guards against. Drop to the owning user for fetch/reset rather than
bypassing the check; run directly when root-owned or not running as root.
@coderabbitai

coderabbitai Bot commented Jun 11, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@jaylfc, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 23 minutes and 26 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 808994f0-3de0-42c6-8f41-5ca941a2138e

📥 Commits

Reviewing files that changed from the base of the PR and between 8666fe2 and 3dcdb19.

📒 Files selected for processing (1)
  • scripts/install-server.sh
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dev

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

Copy link
Copy Markdown

👋 Thanks for the PR! This one targets master, which is our
stable branch (it's what live installs track). Please retarget it to
dev — click Edit next to the PR title and change the base
branch dropdown from master to dev. Your commits and any review
carry over, nothing is lost.

See CONTRIBUTING.md for the branch model.

@jaylfc
jaylfc merged commit 2c35654 into master Jun 11, 2026
13 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in TinyAgentOS Roadmap Jun 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

execution error: dubious ownership in repository

1 participant