Skip to content

Wait for both coverage uploads before notifying - #289

Merged
philipcraig merged 1 commit into
mainfrom
codecov-after-n-builds
Sep 2, 2026
Merged

Wait for both coverage uploads before notifying#289
philipcraig merged 1 commit into
mainfrom
codecov-after-n-builds

Conversation

@philipcraig

Copy link
Copy Markdown
Collaborator

Codecov posts the project status after the first upload, so the runtime-only report is compared against a base that also carries the consteval flag and fails the 1% threshold (seen on #282). Set after_n_builds: 2 so the comparison waits for both uploads.

@philipcraig
philipcraig requested a review from jbcoe as a code owner September 2, 2026 11:12
@philipcraig
philipcraig enabled auto-merge (squash) September 2, 2026 11:14

@jbcoe jbcoe left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. The previous setup did confuse me a bit.

@philipcraig
philipcraig merged commit 987b1bd into main Sep 2, 2026
13 checks passed
@philipcraig
philipcraig deleted the codecov-after-n-builds branch September 2, 2026 11:22
@codecov

codecov Bot commented Sep 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.87%. Comparing base (d9ca248) to head (66905c1).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #289   +/-   ##
=======================================
  Coverage   72.87%   72.87%           
=======================================
  Files           9        9           
  Lines         822      822           
  Branches      208      208           
=======================================
  Hits          599      599           
  Misses         24       24           
  Partials      199      199           
Flag Coverage Δ
consteval 97.46% <ø> (ø)
runtime 70.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants